From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E88F02E62C for ; Wed, 31 Jul 2024 17:47:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722448076; cv=none; b=cMws99IIijgNfknrJ/TKPy0+CrTT2DjM+5g+eY0CkgqZY1WKBOK1lGbdmaG25/sS2mD2I27O3zQOlTiOycWZMwpoc7wBtih8m377kFqshXl/LbVv/tnzGQH9TG3cxNKjQU/xqQEjl2jKWKk1RaQlmDyfRNDgTCkYIzu1DXEjet0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722448076; c=relaxed/simple; bh=6jAUuW7/ivNq+Elvq+AsbUz2cQ7h+vFt+C9fBmkMu1Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UquT1kCN8ehC7BCcaOplbDxYbvDysF14nmFb7AbjmdLGNzUqYOAPaqHnqZD8cpWetlO1UYDH0gGZGoul7rMpK4CrCq1+twltqVxIJqNKT9cmWTnGiaMMe4mMBZGCxuzfTwVm3IzQsbXuyC898LD9QZ80ABY5+SwKdRFIsA/aptU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QFYJJGWO; arc=none smtp.client-ip=209.85.166.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QFYJJGWO" Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-81f7faff04dso38205939f.1 for ; Wed, 31 Jul 2024 10:47:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722448073; x=1723052873; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=89oZyEHSOTKQRd9fOydMJ2/AkOE+4xTOTMGuEKoBp3k=; b=QFYJJGWOhD8sMtSKnPz2iG8qgnWbyJ/SQb/kQjdBaPxrHE/D96SRs8TNNv44EOBDTh eFzPOTltoo15r7qovNSHTpSBf1/FSeRt8ZjAjclFketqMTFyhOt6YkLIbGYz+s7GlEuV imqtGJHguuOkLADieVI2l8tEYBiffyEhv4kFI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722448073; x=1723052873; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=89oZyEHSOTKQRd9fOydMJ2/AkOE+4xTOTMGuEKoBp3k=; b=TMUjp88dWMCS/FOc68r3xEhX1WzJQh/Z67TjAusF8jEKXtJh2HMPRYdEYOJK8jdIQ9 ri3UqjtkvXqQvUFbTNTVRHp4zBetwEWX7b5uBZxk+kk3uoZukDTdCbGbIzSmK2NCBEc3 YaDzaXFgEIl9+GmpqChMmBluAjIlAVYcitVR5NOFu+Q5Jn4VL/W8NoJggViskQ8cYJWY /BvuzFkOYL2Fe3Fy+EY+uvkwHWPN3BpiNvBOJkiLrqQF05MvaavNJzxhaNYfzG6cZQj4 C87ZT4w2xMSaMG38spj48Fm+BTQ4h3X6O6X2KgHD8/ganiBSgXEEB5yqY9tI2/8AIaQt ebwA== X-Forwarded-Encrypted: i=1; AJvYcCV7ni3fqD+LwzGsuqNddqoClnWQ6v00P9FIEPgpzudHSoSxILBr/f46hsI5vnysD//RhNk0ZxN1uwsReLUWd6s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5noqu+7DQcqMlynxfj6jBCreyFVR0wx0dGXdvaH7rw9JwSDz3 lOFvRFGhnKNUZnW0hDP+VxFZaDrkqLi5tyV8UdP2pKjc6iS+oWB8/oX1/mbLzaytVly8AY4EsaX w X-Google-Smtp-Source: AGHT+IEhJu3l0EIAj6YjUUurkN2Co+0z9S6OdQ7KpdRzQff+24Fw5qN8NoTOnlbNR3NsSWXea1YNyg== X-Received: by 2002:a05:6602:586:b0:80a:9c66:3842 with SMTP id ca18e2360f4ac-81fcc17995bmr1839239f.3.1722448073025; Wed, 31 Jul 2024 10:47:53 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4c29fa40509sm3268043173.7.2024.07.31.10.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 10:47:52 -0700 (PDT) Message-ID: <2a62bb4c-f701-482c-b83d-ec3e489b0f7e@linuxfoundation.org> Date: Wed, 31 Jul 2024 11:47:52 -0600 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests: ksft: Fix finished() helper exit code on skipped tests To: Muhammad Usama Anjum , Laura Nao , shuah@kernel.org Cc: gregkh@linuxfoundation.org, nfraprado@collabora.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Shuah Khan References: <20240730102928.33182-1-laura.nao@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/31/24 07:05, Muhammad Usama Anjum wrote: > On 7/30/24 3:29 PM, Laura Nao wrote: >> The Python finished() helper currently exits with KSFT_FAIL when there >> are only passed and skipped tests. Fix the logic to exit with KSFT_PASS >> instead, making it consistent with its C and bash counterparts >> (ksft_finished() and ktap_finished() respectively). >> >> Reviewed-by: Nícolas F. R. A. Prado >> Fixes: dacf1d7a78bf ("kselftest: Add test to verify probe of devices from discoverable buses") >> Signed-off-by: Laura Nao > Reviewed-by: Muhammad Usama Anjum > >> --- >> This is a revised version of the patch initially submitted as "[PATCH] >> selftests: ksft: Track skipped tests when finishing the test suite": >> https://lore.kernel.org/all/20240722154319.619944-1-laura.nao@collabora.com/ >> >> Depends on "[PATCH v2 2/3] kselftest: Move ksft helper module to common >> directory": >> https://lore.kernel.org/all/20240705-dev-err-log-selftest-v2-2-163b9cd7b3c1@collabora.com/ >> (picked through the usb tree, queued for 6.11-rc1) >> >> Changes in v2: >> - Reworded the commit title and message to more accurately describe the >> incorrect behavior of the finished() helper addressed by the patch. Thank you - Applied to linux-kselftest fixes for Linux 6.11-rc2 thanks, -- Shuah