Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Dev Jain <dev.jain@arm.com>, shuah@kernel.org, oleg@redhat.com
Cc: mingo@kernel.org, tglx@linutronix.de, mark.rutland@arm.com,
	ryan.roberts@arm.com, broonie@kernel.org, suzuki.poulose@arm.com,
	Anshuman.Khandual@arm.com, DeepakKumar.Mishra@arm.com,
	aneesh.kumar@kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v5 1/2] selftests: Rename sigaltstack to generic signal
Date: Tue, 27 Aug 2024 05:38:17 -0600	[thread overview]
Message-ID: <2b6112b1-ce10-4e14-87d4-04d64972be56@linuxfoundation.org> (raw)
In-Reply-To: <51617076-3aec-413d-bf42-cf1c359a0c38@arm.com>

On 8/22/24 05:10, Dev Jain wrote:
> 
> On 8/22/24 08:33, Shuah Khan wrote:
>> On 8/21/24 00:15, Dev Jain wrote:
>>> Rename sigaltstack to signal, and rename the existing test to
>>> sigaltstack.c.
>>
>> Can you elaborate on the benefits if renaming the test?
>>
>> Also you have such a good information in the cover-letter for this
>> patch - it would be good to include it in the change log for this
>> one or the new test.
> 
> Okay.
> 
> 
>>
>> The new test itself is good. I don't understand the value of renaming.
>> I can see the problems due to not being able to fix stables if the
>> existing test needs fixing. If there are good reasons for renaming,
>> I am all for it.
> 
> After looking into some git history, now I understand that "sas" actually
> has some meaning, although I still can't find its full-form :) I thought that
> sigaltstack would be a better name, but I guess sas is a subset of sigaltstack
> as part of SA_ONSTACK. So, let us drop the renaming of the test.
> 

I assume you will be sending a new v6 patch series without the renaming and just the
new test?

thanks,
-- Shuah


  reply	other threads:[~2024-08-27 11:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21  6:15 [PATCH v5 0/2] Add test to distinguish between thread's signal mask and ucontext_t Dev Jain
2024-08-21  6:15 ` [PATCH v5 1/2] selftests: Rename sigaltstack to generic signal Dev Jain
2024-08-22  3:03   ` Shuah Khan
2024-08-22 11:10     ` Dev Jain
2024-08-27 11:38       ` Shuah Khan [this message]
2024-08-27 11:43         ` Dev Jain
2024-08-21  6:15 ` [PATCH v5 2/2] selftests: Add a test mangling with uc_sigmask Dev Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b6112b1-ce10-4e14-87d4-04d64972be56@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=Anshuman.Khandual@arm.com \
    --cc=DeepakKumar.Mishra@arm.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=broonie@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox