From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F73F34DCEE for ; Thu, 19 Mar 2026 19:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773950217; cv=none; b=rpVQYpEDfQ08Lg870B/gy4mvLLSTm8snbx19+HsUqmYdqhxFEOrLaTHTTxg5WOOuGFqhtxOIongMsOTJxLweEib8CJf+YJ5KdujAqb3f3h6qOsNTwHmLjvofCsGjyaMytKf1Xz0kM5Znc64vrWudXUMZKh1wGpJ9EDH4CNtLSdA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773950217; c=relaxed/simple; bh=A5ZzQf31sXGiyMkHY7CP5QbAbk7vbbn517yUbBfo44s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C1uKViLHwIqsEP93NZW/o6yxZ/7kiBxcHds/w/A4cWTCOUftkK+bB13jBCsWvRGwEuIw8/eCzOSJfZd81XOb8sOHl2nhZd00sNdO9L87Y7JqXN83DgzfUWyyNcDAUz+s+okK6e9d0XGiUxntVyX1V6kwHy2j6FuPmvu77aSS0Ls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=XxvOS7+M; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="XxvOS7+M" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id AB2254E42721; Thu, 19 Mar 2026 19:56:53 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 6904460050; Thu, 19 Mar 2026 19:56:53 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 507AB10450A9C; Thu, 19 Mar 2026 20:56:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773950212; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=cm39P2d/41DdSfdDZCfUJLAJ/BGyonppmELDf76R9UI=; b=XxvOS7+Mr7dkDyD+4Xtt6WqyG1iBNRgP8jj9BFlmVqB91FM5yVSIyhwAlfC5kl04J/r4Gv wwCGP/Iw8BUpDmvdgZkmpGZQQQsZmTVkmM+fI+hYdUlK8Vsxg/epPiLaAPct53XF7h6Eg5 pQ7t9JP+H2hhL+W7NuPQGbKbY58U5FIY0bgwAj43f8MK48vYmMw7I7j9P5OvI1tzG7ofa7 OXa3RZYyEwEGS5vCQ/ES3WpX0eT+xEl32oiWJeQllbIFgDd6P0suFjfT/Dul/S0VmATgtR GDma6ce4742Ti2GK9Dxk9MMUm6Luv7YV7bzbWa+QDEnzVJkYWQw0PWL0WbS29g== Message-ID: <2e4a7b45-8029-425e-8b86-9f3031bd081e@bootlin.com> Date: Thu, 19 Mar 2026 20:56:46 +0100 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/2] net: page_pool: support dumping pps of a specific ifindex via Netlink To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, donald.hunter@gmail.com, shuah@kernel.org, matttbe@kernel.org, chuck.lever@oracle.com, hawk@kernel.org, linux-kselftest@vger.kernel.org References: <20260319035649.2396137-1-kuba@kernel.org> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20260319035649.2396137-1-kuba@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Jakub, On 19/03/2026 04:56, Jakub Kicinski wrote: > NIPA tries to make sure that HW tests don't modify system state. > It saves the state of page pools, too. Now that I write this commit > message I realize that this is impractical since page pool IDs and > state will get legitimately changed by the tests. But I already > spent a couple of hours implementing the filtering, so.. > > Signed-off-by: Jakub Kicinski [...] > diff --git a/net/core/page_pool_user.c b/net/core/page_pool_user.c > index ee5060d8eec0..01509d1b3cba 100644 > --- a/net/core/page_pool_user.c > +++ b/net/core/page_pool_user.c > @@ -79,7 +79,7 @@ struct page_pool_dump_cb { > > static int > netdev_nl_page_pool_get_dump(struct sk_buff *skb, struct netlink_callback *cb, > - pp_nl_fill_cb fill) > + pp_nl_fill_cb fill, struct nlattr *ifindex_attr) > { > struct page_pool_dump_cb *state = (void *)cb->ctx; > const struct genl_info *info = genl_info_dump(cb); > @@ -88,9 +88,17 @@ netdev_nl_page_pool_get_dump(struct sk_buff *skb, struct netlink_callback *cb, > struct page_pool *pool; > int err = 0; > > + if (ifindex_attr) > + state->ifindex = nla_get_u32(ifindex_attr); > + > rtnl_lock(); > mutex_lock(&page_pools_lock); > for_each_netdev_dump(net, netdev, state->ifindex) { > + /* Either the provided ifindex doesn't exist or done dumping */ > + if (ifindex_attr && > + netdev->ifindex != nla_get_u32(ifindex_attr)) > + break; If the passed ifindex doesn't exist, isn't netdev NULL here ? Maxime