From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B07739D6F8 for ; Wed, 13 May 2026 22:33:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778711630; cv=none; b=SbUdErYJyAmviyou24GajVZnZcQ2yON9bZDUtTGZOJ7s7mEcfrAr+1GeVpZSLhQLDlU/KILRi7Z9WLBCWW9x7ETeQeFcVOSPq9NSA+hexgUAWGppisnv7xSMi1HexXh/uS5GaXjaNgVnR4svQYD/2cFwjMXbj1DY7RhhMty0zWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778711630; c=relaxed/simple; bh=kgA0KAea695MAc8LHoG5EseKaGFUKSpbXPmYExsdEug=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=auDLabtiX0PcGUq15kf1GpZjQvdylOz12MmCkrcb28IQ3btnyiJJYmdWaD6tGTdkiCbylPjeGPzEYIgLq8WIXsFx5CDqQK2kAr7kErRdgVblrP+w99SSjgotyNbX/gKtYokyXTMnOsKutvKQAMq2csHvDVKs3KLJX5exMcSFtOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VnHmWezM; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VnHmWezM" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-2f7020a928eso10296777eec.1 for ; Wed, 13 May 2026 15:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778711628; x=1779316428; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=kgA0KAea695MAc8LHoG5EseKaGFUKSpbXPmYExsdEug=; b=VnHmWezMo0YlbCNcA++RfdlNu1SAfug0zNNW+AX2t6EAp7QeMQCIqBLPh9tYDkgJn/ Ukjlom+POn5HpSnk683AJE96NFrKsWoEOtWmHsQzraB917NphnoaZ4WfEa1S6pQ/jCJY Xu7TMuRJ79epD8mXu+HYjS7UN97TZmYuJYHvbjxNeniFR3pf6GuSDGcuvgfqBypKmW3L EZlQWBd8gtqqFqvbjtD6dd8xsGCG2rMAgqmJAqxfNvdt3Z0ZRHupXQwRdBgQkVX81l0e Cw4KrJS3DEIv7lawH2dowOP0mBVBTS8xR+eRmiHNMMTmUWyY0cGm0t6hUwjm6iI6ur44 LvCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778711628; x=1779316428; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kgA0KAea695MAc8LHoG5EseKaGFUKSpbXPmYExsdEug=; b=BBbk8ip8H58XN9/NC+WgpMhi/lk//VAMYQkNV2ryIJSmRyb3LWuyWlzvmUnNq8xtPR GvInD2X9A3Rics8nDoNCMFOcLgZrcuSpy341i5Ad+UIv3KYwpAnxqYd31+k5XyFrbr4x fyGCjN41NhPMDgiSKg561XDfk+eY6HcUKsnSLty5w00Iy7Turxvn5O095PvFih3f0EcA bTYq/hPihmRzfW0bFeugJqL9q/ia5a8Ze2bfhoEnf8r7Ohoj51WSsvqEiMY2Wvqp9gwH yk8aMg8FHAfWmklBUi/H6FKcdo98SHQjkBNcxSIGPZMjD81E3UCGDyR+UJMwnVmmTKzz gxQQ== X-Forwarded-Encrypted: i=1; AFNElJ/v4POuli6SpUx1MTOsetvi+R9ciUZx5GqIrbGc3HPTMCx7JvTj0k3VXxtqyMj/aQqgzMVG0UU+WgBCzE5WPM0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxw407CmGGhiAkeFXJLElGy+wOnZCPUWbNGdHt8iBonsUwodjSu UspyzrF+3H5x8RwowMCqRNjKmBalTOiGLBaioNGPXXftAfGwZ+NJ20YR X-Gm-Gg: Acq92OFbKQ66ECEtZOJMRn2KLtpG9xVvEboOrjv5prxCEMk+6gnoUqkYe3qzL38C9Vp LmH9v13DaFXez09W6MyG1ekowojfGlI06mz6NuNNN31dyZeI7BBKX5gOOZkZUVTtpTzdQ4RGJEr hHw0Oz1CBEEP6CA+jQJsD/iV8NkNB7Gbag2+PvUORp/S88fwutPLBLNzq8Wlmm7y0a4562H5Hts fDNpbgnvTghgPHsLI7a/DCBjD3fWrjGDUQ+KvgGU2CLN1bx5cofcAY/P2Wy1kg2S+9sQn4UyvW4 eAyTIp+wgw3ZRNfbxejIC1IRqWbWHZsgm6H7wZuhWjMWWecdmsoA+4QC/Qxbx7Wa+64XDfIlipk A2qE/oZjRLaG3pqMnCt76qjlYXn1B5m6luMGKj2o14XFsb7l8VYGW4cnuSFYTP43ja2vM4HudDN Q9NtCx2uAV83cGo+Hl4RSQBKO635CLDT4+M0r4mMYfi8LBuN0JzZDMKJic2zhgCa6G9cWstm8Nh w4VJo8= X-Received: by 2002:a05:7300:c87:b0:2d9:6f2f:9f6f with SMTP id 5a478bee46e88-30119f5955dmr2880656eec.24.1778711627516; Wed, 13 May 2026 15:33:47 -0700 (PDT) Received: from ?IPv6:2a03:83e0:115c:1:5152:641f:f5ef:6c7b? ([2620:10d:c090:500::2:8a9]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30297bbc9a3sm718642eec.31.2026.05.13.15.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 15:33:47 -0700 (PDT) Message-ID: <2ec40641b6d0313674557a682984d7ea9cdf24a4.camel@gmail.com> Subject: Re: [PATCH RESEND bpf-next v10 4/8] bpf: refactor __bpf_list_add to take insertion point via **prev_ptr From: Eduard Zingerman To: Kaitao cheng , ast@kernel.org, corbet@lwn.net, martin.lau@linux.dev, daniel@iogearbox.net, andrii@kernel.org, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, chengkaitao@kylinos.cn, skhan@linuxfoundation.org, memxor@gmail.com Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, vmalik@redhat.com, linux-kselftest@vger.kernel.org Date: Wed, 13 May 2026 15:33:44 -0700 In-Reply-To: <20260512055919.95716-5-kaitao.cheng@linux.dev> References: <20260512055919.95716-1-kaitao.cheng@linux.dev> <20260512055919.95716-5-kaitao.cheng@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-05-12 at 13:59 +0800, Kaitao cheng wrote: > From: Kaitao Cheng >=20 > Refactor __bpf_list_add to accept (node, head, struct list_head **prev_pt= r, > ..) instead of (node, head, bool tail, ..). Load prev from *prev_ptr afte= r > INIT_LIST_HEAD(h), so we never dereference an uninitialized h->prev when > head was 0-initialized (e.g. push_back passes &h->prev). >=20 > When prev is not the list head, validate that prev is in the list via > its owner. >=20 > Prepares for bpf_list_add(head, new, prev, ..) to insert after a given > list node. >=20 > Signed-off-by: Kaitao Cheng > --- Reviewed-by: Eduard Zingerman [...]