From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794917982; b=MUtgSTCHbyTaybPKmWMZY/YtvNdtFoSvb2/sV8O4aFvcelAz4DyD7q5AHQUPHoUHK4x3 bPDDfSTOSrEZ3aV3TLnwFGk+We4+tdBVYYHccL20z6sdZfdZI74hMykaXI1Raa86yzxjs L+0fq9ZRiES6sao2l7ro4zBoRpnEY0aauR2iQaJhB+VCm1p0sEWC5YThkPmfS6a4YOy6J +bnezPbX/gN18y3Hai5j3TiPCxRPwmUybLFWxmcoH6ja/JDCvyiA/I6oMsqEI7oeZq54y KsVtDEtOonSkq0I3Xr58HS4OjdshQGTCb0J1xzhqkyjLXVwNXQBSG+O4CnhRMHORnoQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794917982; h=Received:DKIM-Signature:From:To:Cc:Subject:In-Reply-To:References: Date:Message-ID:User-Agent:MIME-Version:Content-Type; bh=8qHTsTGMbRUu4uHJjKWa8mMXyZqa434909JPIyvfASg=; b=xw33tWADPUqFcfIJCqDiONWLZzKzlSS9dKblKTj2lYq2rQJl+pkRJPjJV78XjmJyU/hr Wl10e1L5JadXVmbR9ys+cuJd64WkIt2fm5pH+jDfrKrzZSZ0Q3Q7hVEm4blP5nEEgG8rT MeF9Ls+NJbC0luSK80Q6URnvGsLtOUWs6WjaqOkFG4BE9V55EQU9BH4pY1jS1qRx7ZxrK hLRKcx2TnOghiqqO2+eKsFDmkdQAsy7hPAx0FYjREoiukstng5YiYjOEhN2+FMtnyyxsY LT9erpRs8S3UfVtTWmTMywEE/tNSTdLsa1/l0NlVmfab3f76MECRLS3FDTRoaz4C47g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=J7Lr7h2H; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48834606A8AA; Tue, 17 Nov 2026 12:19:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=J7Lr7h2H Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63DB71F000C4; Tue, 17 Nov 2026 12:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794917982; bh=8qHTsTGMbRUu4uHJjKWa8mMXyZqa434909JPIyvfASg=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=J7Lr7h2HCcgTuVQeG8fRdX1IORtvd+WG/QKrKgksiuuBAwy5PUrWttWaBgbQS4H8S +EgMMP+IqOirMk9hGcIyY9WsoYaVKR0dIYN7CN65qdqCDdOQqVenj6SaYIGh3iXEv9 U+6Di/xavaw+hN85Ql0/4V6FUOGEPFsmDMcWMCC+wcDkXdAuxucNzfsGSW5rfi6Vo+ PHXlulLyptBwr4ni6mh56hYPqWO77XVkXAK4NMXl3X6siimEarGlGJVr7FogKDftmU vkZMZLknl5jyFa6uP8mzNs8f3AWWO6MYFfTrD/3tElPEzr1KANCYN6qsP8TS8l+lcj 7xe/CNz6RyxGw== From: Pratyush Yadav To: Chris Down Cc: Pratyush Yadav , Mike Rapoport , Pasha Tatashin , Alexander Graf , Jonathan Corbet , Shuah Khan , Randy Dunlap , Andrew Morton , Tarun Sahu , David Matlack , Samiullah Khawaja , kexec@lists.infradead.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC PATCH 0/5] KHO map In-Reply-To: (Chris Down's message of "Tue, 17 Nov 2026 02:10:14 -0800") References: <20261116134013.1636689-1-pratyush@kernel.org> Date: Tue, 17 Nov 2026 13:19:38 +0100 Message-ID: <2vxz1p8jhcpx.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain Hi Chris, On Tue, Nov 17 2026, Chris Down wrote: > Hi Pratyush, > > Pratyush Yadav writes: >>The main user of the map is memfd. Currently memfd uses a vmalloc buffer >>that has a pair of {index,pfn} to track the folios in the file. That >>uses 16 bytes per page. The KHO map uses only 8 bytes per page with some >>overhead. So for a 1 GiB memfd, it uses roughly half the memory. > > That only holds for order-0 folios though. A leaf covers 512 indices, so > a populated memfd needs one leaf page for every 2M of file whatever the > folio size, while the array needs 16 bytes per folio. Per 2M of file, > that works out as: > > folio size array map map/array > 4K (o0) 8K 4K 0.5x > 8K (o1) 4K 4K 1x > 16K (o2) 2K 4K 2x > 64K (o4) 512 4K 8x > 2M (o9) 16 4K 256x Right. > >>- Multi-index entry support: currently, while the map is very efficient >> with 4k folios, it is horribly inefficient with 2M folios. Each folio >> in the memfd takes up a full page to track. Multi-index entry support >> can fix this by tracking entries that cover a whole page in the >> previous level, similar to page tables. > > Since patch 5 makes things worse for memfds with large folios, I agree > with Pasha that this needs fixing before memfd switches over. Storing Right, I agree as well. > PMD-sized entries at L1 fixes the 2M case, but mTHP sizes between 4K and > 2M would still take a full leaf for every 2M of file. Do you expect > mTHP-backed memfds to be preserved? If so, it's probably worth handling > them in the format before it becomes ABI. mTHP will still work, it will just be less space efficient than 2M THPs. Even then, the overhead is around 2M for every 1G, which is roughly 0.2%. Even then, I don't think that is too bad. If you want to be more space efficient, use 2M THPs, or hugetlb[*]. I think that is a fair tradeoff. Using larger page sizes also makes KHO more efficient. We _can_ make mTHPs fairly efficient, but that comes at the cost of a more complicated ABI. For example, we can have a per-order KHO map in the memfd, and shift the keys by the order. That should improve the density. We could also do some other tricks like the shifted key encoding scheme that KHO preserved memory map uses (see kho_encode_radix_key()) to improve density. So unless someone can explain why mTHP memfds are important to optimize for, I'd say mTHP users can either take the 0.2% preservation overhead, or use 2M THPs. [*] I sent an RFC for that some time ago, but it's been blocked on pending infrastructure rework like extended bootmem. I plan to send out a refreshed version soon. -- Regards, Pratyush Yadav