From: Pratyush Yadav <pratyush@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: David Matlack <dmatlack@google.com>,
kexec@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org, Alexander Graf <graf@amazon.com>,
Andrew Morton <akpm@linux-foundation.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
David Hildenbrand <david@kernel.org>,
Hugh Dickins <hughd@google.com>,
Jonathan Corbet <corbet@lwn.net>,
"Liam R. Howlett" <liam@infradead.org>,
Lorenzo Stoakes <ljs@kernel.org>,
Michal Hocko <mhocko@suse.com>, Mike Rapoport <rppt@kernel.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Pratyush Yadav <pratyush@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Samiullah Khawaja <skhawaja@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@kernel.org>
Subject: Re: [PATCH v4 08/19] liveupdate: Let file handlers retrieve into an existing file
Date: Fri, 20 Nov 2026 11:36:01 +0000 [thread overview]
Message-ID: <2vxz7bi73fby.fsf@kernel.org> (raw)
In-Reply-To: <20261120-gedulden-rausgeflogen-spruch-cea76174d5e2@brauner> (Christian Brauner's message of "Fri, 20 Nov 2026 10:23:28 +0100")
On Fri, Nov 20 2026, Christian Brauner wrote:
> On Wed, Nov 11, 2026 at 12:23:46AM +0000, David Matlack wrote:
>> A file that is restored into an existing file is already open in the
>> caller, so installing a new file descriptor for it would just leave
>> userspace with two file descriptors for the same open file. Retrieving
>> the token again later still returns a new file descriptor, like for any
>> other file that was already retrieved.
>
> Thanks, this looks way better.
>
> One thing: Please just install a new fd like for every other retrieve.
> I think it's pretty meaningless to return the fd number the userspace
> just passed to the ioctl.
>
> The fd number is also not useful as it's not tied to anything. The shmem
> handler looks the fd up once and LUO keeps a reference to the struct
> file:
>
> CLASS(fd, target)(arg->fd);
> [...]
> args->file = get_file(file);
> args->fd = arg->fd;
>
> Which means, another thread can close() that fd or dup2() something else
> over it before the ioctl returns and the fd you hand back refers to a
> different file fucking over the caller (shared fdtable etc pp).
>
> That also gets rid of @fd in struct liveupdate_file_op_args and the
> special case in luo_session_retrieve_fd(). And a retrieve into an
> existing file then behaves exactly like retrieving the token again.
I suggested this approach because I found it odd to return a FD that
userspace already asked us to retrieve into. Any sane userspace would
just end up closing one of the two. I didn't think of this race though.
I reckon we could return -1 in the FD that LUO returns, and let
userspace use the FD it already has to work around this. If userspace
wants to close the FD in the meantime, that's their problem. They don't
get the file they asked for.
While I like this more, it's not a super strong preference. So if you
still insist on having a new FD, that's fine too I suppose.
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2026-11-20 11:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 0:23 [PATCH v4 00/19] liveupdate: Preserve tmpfs files across Live Update David Matlack
2026-11-11 0:23 ` [PATCH v4 01/19] liveupdate: Remove the list of steps from luo_preserve_file()'s comment David Matlack
2026-11-19 18:26 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 02/19] liveupdate: Pass user argument to file preserve and retrieve David Matlack
2026-11-11 0:23 ` [PATCH v4 03/19] selftests/liveupdate: Add tests for preserve and retrieve user argument David Matlack
2026-11-11 0:23 ` [PATCH v4 04/19] liveupdate: Allow file handlers to mark retrieve failures as retryable David Matlack
2026-11-19 18:38 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 05/19] mm: Rename memfd_luo to shmem_luo David Matlack
2026-11-11 0:23 ` [PATCH v4 06/19] liveupdate: Don't WARN if tracking a retrieved file fails David Matlack
2026-11-20 9:58 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 07/19] liveupdate: Add helpers to track the files that LUO manages David Matlack
2026-11-20 11:15 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 08/19] liveupdate: Let file handlers retrieve into an existing file David Matlack
2026-11-20 9:23 ` Christian Brauner
2026-11-20 11:36 ` Pratyush Yadav [this message]
2026-11-11 0:23 ` [PATCH v4 09/19] mm/shmem_luo: Leave freeing the preserved state to finish() David Matlack
2026-11-11 0:23 ` [PATCH v4 10/19] mm/shmem_luo: Don't make early retrieve failures permanent David Matlack
2026-11-11 0:23 ` [PATCH v4 11/19] mm/shmem_luo: Require permission to preserve a file David Matlack
2026-11-11 0:23 ` [PATCH v4 12/19] mm/shmem_luo: Retrieve tmpfs files into a file created by userspace David Matlack
2026-11-11 0:23 ` [PATCH v4 13/19] mm/shmem_luo: Allow preserving tmpfs files David Matlack
2026-11-11 0:23 ` [PATCH v4 14/19] selftests/liveupdate: Test which tmpfs files can be preserved David Matlack
2026-11-11 0:23 ` [PATCH v4 15/19] selftests/liveupdate: Add a test for retrieving tmpfs files David Matlack
2026-11-11 0:23 ` [PATCH v4 16/19] selftests/liveupdate: Test memfds and LUO interactions in luo_tmpfs David Matlack
2026-11-11 0:23 ` [PATCH v4 17/19] selftests/liveupdate: Test the targets of retrieved tmpfs files David Matlack
2026-11-11 0:23 ` [PATCH v4 18/19] selftests/liveupdate: Test retrieving tmpfs files preserved read-only David Matlack
2026-11-11 0:23 ` [PATCH v4 19/19] selftests/liveupdate: Test block accounting of retrieved tmpfs files David Matlack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2vxz7bi73fby.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=david@kernel.org \
--cc=dmatlack@google.com \
--cc=graf@amazon.com \
--cc=hughd@google.com \
--cc=kexec@lists.infradead.org \
--cc=liam@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=skhawaja@google.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox