From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Muhammad Usama Anjum <usama.anjum@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shuah Khan <shuah@kernel.org>,
Andrey Konovalov <andreyknvl@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Amit Daniel Kachhap <amit.kachhap@arm.com>,
Yeoreum Yun <yeoreum.yun@arm.com>,
Mark Brown <broonie@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
<linux-arm-kernel@lists.infradead.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] selftests/arm64: Treat KSM merge_across_nodes as optional
Date: Wed, 26 Aug 2026 09:26:40 +0100 [thread overview]
Message-ID: <30d29c7a-3d66-498f-9777-8dadbb0a4584@arm.com> (raw)
In-Reply-To: <20260825111929.2882324-3-usama.anjum@arm.com>
On 25/08/2026 12:18, Muhammad Usama Anjum wrote:
> The MTE KSM test requires write access to KSM sysfs but does not check
> that it is running as root. It also unconditionally saves, enables and
> restores the merge_across_nodes attribute. The kernel only creates this
> attribute when CONFIG_NUMA=y, so a non-NUMA kernel prints the following
> message three times even though every KSM subtest passes:
>
> # ERR: missing /sys/kernel/mm/ksm/merge_across_nodes
>
> Skip the test when it is not running as root. Check that the optional
> attribute is readable and writable, treating ENOENT as its expected
> absence on non-NUMA kernels and skipping the test for other access
> failures. Only save, enable and restore the attribute when it is
> available.
>
> Check MTE availability before the privilege and sysfs checks so systems
> without MTE retain the existing feature-unavailable skip result.
>
> This preserves the existing behavior on NUMA kernels without requiring
> NUMA or reducing KSM coverage on single-node systems.
>
> Fixes: f981d8fa2646 ("kselftest/arm64: Verify KSM page merge for MTE pages")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@arm.com>
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
...
next prev parent reply other threads:[~2026-08-26 8:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 11:18 [PATCH v3 0/4] selftests/arm64: Fix MTE test setup and TAP reporting Muhammad Usama Anjum
2026-08-25 11:18 ` [PATCH v3 1/4] selftests/arm64: Print missing MTE TAP headers Muhammad Usama Anjum
2026-08-25 13:58 ` Mark Brown
2026-08-26 8:25 ` Vincenzo Frascino
2026-08-25 11:18 ` [PATCH v3 2/4] selftests/arm64: Treat KSM merge_across_nodes as optional Muhammad Usama Anjum
2026-08-25 14:00 ` Mark Brown
2026-08-26 8:26 ` Vincenzo Frascino [this message]
2026-08-25 11:18 ` [PATCH v3 3/4] selftests/arm64: Fix MTE prctl TAP plan Muhammad Usama Anjum
2026-08-26 8:27 ` Vincenzo Frascino
2026-08-25 11:18 ` [PATCH v3 4/4] selftests/arm64: Add MTE test config fragment Muhammad Usama Anjum
2026-08-26 8:27 ` Vincenzo Frascino
2026-08-27 15:22 ` [PATCH v3 0/4] selftests/arm64: Fix MTE test setup and TAP reporting Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30d29c7a-3d66-498f-9777-8dadbb0a4584@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=akpm@linux-foundation.org \
--cc=amit.kachhap@arm.com \
--cc=andreyknvl@gmail.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shuah@kernel.org \
--cc=usama.anjum@arm.com \
--cc=will@kernel.org \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox