From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED0CEECAAA1 for ; Tue, 6 Sep 2022 15:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231947AbiIFPtL (ORCPT ); Tue, 6 Sep 2022 11:49:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232995AbiIFPry (ORCPT ); Tue, 6 Sep 2022 11:47:54 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDAF7C7B98 for ; Tue, 6 Sep 2022 07:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662476279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uYOnT3WdHbcwCr8H+t7+tWjbf0atY1c9YvOA6+hgbSo=; b=iYD8lxCC7BzbgfSAmJBSpeCH9ZgFVfPI6GT+SCoOu5EFA08i1p0hQdjyP2GqQRGemGnAR/ UlvZPnhN+d0hhF+BGGL2SImSKh5uk/ZVx1Azf4AD/38N88pyyVNHDrOGGA8JLv049L5rUo vFJ99dC1zAZZ9dEK0v8+Tq3c9+3hxBQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-457-_IgzUhngPAiRRZqjq7yHDw-1; Tue, 06 Sep 2022 10:57:54 -0400 X-MC-Unique: _IgzUhngPAiRRZqjq7yHDw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C8C1B1C0BDEA; Tue, 6 Sep 2022 14:57:53 +0000 (UTC) Received: from [10.18.17.215] (dhcp-17-215.bos.redhat.com [10.18.17.215]) by smtp.corp.redhat.com (Postfix) with ESMTP id 120181410F3C; Tue, 6 Sep 2022 14:57:52 +0000 (UTC) Message-ID: <323f6375-0e1b-8326-2c74-b7a4db4693a1@redhat.com> Date: Tue, 6 Sep 2022 10:57:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v12 09/10] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst Content-Language: en-US To: Bagas Sanjaya Cc: Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Shuah Khan , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Roman Gushchin , Phil Auld , Peter Zijlstra , Juri Lelli , Frederic Weisbecker , Marcelo Tosatti , =?UTF-8?Q?Michal_Koutn=c3=bd?= References: <20220901205745.323326-1-longman@redhat.com> <20220901205745.323326-10-longman@redhat.com> From: Waiman Long In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 9/4/22 04:20, Bagas Sanjaya wrote: > On Thu, Sep 01, 2022 at 04:57:44PM -0400, Waiman Long wrote: >> It accepts only the following input values when written to. >> >> ======== ================================ >> - "root" a partition root >> - "member" a non-root member of a partition >> + "member" Non-root member of a partition >> + "root" Partition root >> + "isolated" Partition root without load balancing >> ======== ================================ >> >> >> + On read, the "cpuset.cpus.partition" file can show the following >> + values. >> + >> + ====================== ============================== >> + "member" Non-root member of a partition >> + "root" Partition root >> + "isolated" Partition root without load balancing >> + "root invalid ()" Invalid partition root >> + "isolated invalid ()" Invalid isolated partition root >> + ====================== ============================== >> + > These tables above produced htmldocs warnings: > > Documentation/admin-guide/cgroup-v2.rst:2191: WARNING: Malformed table. > Text in column margin in table line 4. > > ======== ================================ > "member" Non-root member of a partition > "root" Partition root > "isolated" Partition root without load balancing > ======== ================================ > Documentation/admin-guide/cgroup-v2.rst:2229: WARNING: Malformed table. > Text in column margin in table line 5. > > ====================== ============================== > "member" Non-root member of a partition > "root" Partition root > "isolated" Partition root without load balancing > "root invalid ()" Invalid partition root > "isolated invalid ()" Invalid isolated partition root > ====================== ============================== > > I have applied the fixup: > > ---- >8 ---- > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index 76b3ea9fd5c560..77b6faecf066cb 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -2185,11 +2185,11 @@ Cpuset Interface Files > > It accepts only the following input values when written to. > > - ======== ================================ > + ========== ================================ > "member" Non-root member of a partition > "root" Partition root > "isolated" Partition root without load balancing > - ======== ================================ > + ========== ================================ > > The root cgroup is always a partition root and its state > cannot be changed. All other non-root cgroups start out as > @@ -2222,13 +2222,13 @@ Cpuset Interface Files > On read, the "cpuset.cpus.partition" file can show the following > values. > > - ====================== ============================== > + ============================= ===================================== > "member" Non-root member of a partition > "root" Partition root > "isolated" Partition root without load balancing > "root invalid ()" Invalid partition root > "isolated invalid ()" Invalid isolated partition root > - ====================== ============================== > + ============================= ===================================== > > In the case of an invalid partition root, a descriptive string on > why the partition is invalid is included within parentheses. > > Thanks. Thanks for the fixes. Will apply that. Cheers, Longman