From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA995C433DF for ; Tue, 19 May 2020 22:16:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99606207E8 for ; Tue, 19 May 2020 22:16:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589926601; bh=RyWC/bFV8ItGh7pgttI1BldvKPNDCEUggcCOKsPQbqY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=TKEq6irEgDkRZlZSsSpNu18G6uVhSs0HJpO0I862TufyhoCWId6sUPrFCfQICQdO9 XBZxFT+GbdbVX+cjm403dnu+UQW1tJUMJGgRRk67GWE1gJx1Jg0U96UTQM4B0n8LiQ WI6Sq7zxyDcWclB/NS1icmwtXXEQZhnHkZCYOtNU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726318AbgESWQl (ORCPT ); Tue, 19 May 2020 18:16:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:33320 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725998AbgESWQl (ORCPT ); Tue, 19 May 2020 18:16:41 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AD40C2075F; Tue, 19 May 2020 22:16:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589926600; bh=RyWC/bFV8ItGh7pgttI1BldvKPNDCEUggcCOKsPQbqY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=AEjsNdF+gGHFEP7llvxMaPuc9ZKhdIspTY6TmH3231krk1J38kqhjBOKYZSTjHSic KjssEgLzGTEJYERmdw/rEZ9CY79EYw7h0FfMSDwN4URkj3pNgw/WZuyRpvIbM4BOH3 lyT9RicU6ERj4Z4dVyAzXcjocSyJY6MwfhZQ4dYA= Subject: Re: [PATCH v2] selftests: introduce gen_tar Makefile target To: Stefano Brivio , Veronika Kabatova Cc: linux-kselftest@vger.kernel.org, shuah References: <20200519200045.317516-1-vkabatov@redhat.com> <20200519225722.49e4d067@redhat.com> From: shuah Message-ID: <35755630-2653-719d-5684-7cf7cc86fd2b@kernel.org> Date: Tue, 19 May 2020 16:16:40 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200519225722.49e4d067@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 5/19/20 2:57 PM, Stefano Brivio wrote: > On Tue, 19 May 2020 22:00:45 +0200 > Veronika Kabatova wrote: > >> The gen_kselftest_tar.sh always packages *all* selftests and doesn't >> pass along any variables to `make install` to influence what should be >> built. This can result in an early error on the command line ("Unknown >> tarball format TARGETS=XXX"), or unexpected test failures as the >> tarball contains tests people wanted to skip on purpose. >> >> Since the makefile already contains all the logic, we can add a target >> for packaging. Keep the default .gz target the script uses, and actually >> extend the supported formats by using tar's autodetection. >> >> To not break current workflows, keep the gen_kselftest_tar.sh script as >> it is, with an added suggestion to use the makefile target instead. >> >> Signed-off-by: Veronika Kabatova > > Reviewed-by: Stefano Brivio > Applied to git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next for Linux 5.8-rc1. thanks, -- Shuah