From: Eduard Zingerman <eddyz87@gmail.com>
To: Puranjay Mohan <puranjay12@gmail.com>
Cc: KaFai Wan <kafai.wan@linux.dev>,
puranjay@kernel.org, xukuohai@huaweicloud.com, ast@kernel.org,
daniel@iogearbox.net, john.fastabend@gmail.com,
andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org, mykolal@fb.com,
shuah@kernel.org, mrpre@163.com, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf v2 2/2] selftests/bpf: Add socket filter attach test
Date: Thu, 14 Aug 2025 09:06:35 -0700 [thread overview]
Message-ID: <35c18502a4870d8a833c1c9af20b85ca3f8a0ff6.camel@gmail.com> (raw)
In-Reply-To: <CANk7y0hQWOL3OW8Ok4e-kp7Brn5Zq6H5+EfS=mVtoVd+AUxZmA@mail.gmail.com>
On Thu, 2025-08-14 at 13:23 +0200, Puranjay Mohan wrote:
> On Thu, Aug 14, 2025 at 2:35 AM Eduard Zingerman <eddyz87@gmail.com> wrote:
> >
> > On Wed, 2025-08-13 at 23:29 +0800, KaFai Wan wrote:
> > > This test verifies socket filter attachment functionality on architectures
> > > supporting either BPF JIT compilation or the interpreter.
> > >
> > > It specifically validates the fallback to interpreter behavior when JIT fails,
> > > particularly targeting ARMv6 devices with the following configuration:
> > > # CONFIG_BPF_JIT_ALWAYS_ON is not set
> > > CONFIG_BPF_JIT_DEFAULT_ON=y
> > >
> > > Signed-off-by: KaFai Wan <kafai.wan@linux.dev>
> > > ---
> >
> > This test should not be landed as-is, first let's do an analysis for
> > why the program fails to jit compile on arm.
> >
> > I modified kernel to dump BPF program before jit attempt, but don't
> > see anything obviously wrong with it. The patch to get disassembly
> > and disassembly itself with resolved kallsyms are attached.
> >
> > Can someone with access to ARM vm/machine take a looks at this?
> > Puranjay, Xu, would you have some time?
>
> Hi Eduard,
> Thanks for the email, I will look into it.
>
> Let me try to boot a kernel on ARMv6 qemu and reproduce this.
Thank you, Puranjay,
While looking at the code yesterday I found a legit case for failing
to jit on armv6:
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/tree/arch/arm/net/bpf_jit_32.c#n445
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/tree/arch/arm/net/bpf_jit_32.c#n2089
But attached program does not seem to be that big to hit 0xfff boundary.
next prev parent reply other threads:[~2025-08-14 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 15:29 [PATCH bpf v2 0/2] bpf: Allow fall back to interpreter for programs with stack size <= 512 KaFai Wan
2025-08-13 15:29 ` [PATCH bpf v2 1/2] " KaFai Wan
2025-08-13 15:29 ` [PATCH bpf v2 2/2] selftests/bpf: Add socket filter attach test KaFai Wan
2025-08-14 0:35 ` Eduard Zingerman
2025-08-14 11:23 ` Puranjay Mohan
2025-08-14 16:06 ` Eduard Zingerman [this message]
2025-08-16 15:14 ` KaFai Wan
2025-08-25 19:27 ` Puranjay Mohan
2025-08-25 19:32 ` Eduard Zingerman
2025-08-27 11:16 ` Puranjay Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c18502a4870d8a833c1c9af20b85ca3f8a0ff6.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai.wan@linux.dev \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mrpre@163.com \
--cc=mykolal@fb.com \
--cc=puranjay12@gmail.com \
--cc=puranjay@kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=xukuohai@huaweicloud.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).