From: Elizabeth Figura <zfigura@codeweavers.com>
To: shuah@kernel.org, Su Hui <suhui@nfschina.com>
Cc: Su Hui <suhui@nfschina.com>,
wine-devel@winehq.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/4] selftests: ntsync: fix the wrong condition in wake_all
Date: Fri, 14 Mar 2025 17:12:34 -0500 [thread overview]
Message-ID: <3661803.LM0AJKV5NW@camazotz> (raw)
In-Reply-To: <20250314071454.201697-2-suhui@nfschina.com>
On Friday, 14 March 2025 02:14:51 CDT Su Hui wrote:
> When 'manual=false' and 'signaled=true', then expected value when using
> NTSYNC_IOC_CREATE_EVENT should be greater than zero. Fix this typo error.
>
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
> tools/testing/selftests/drivers/ntsync/ntsync.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/drivers/ntsync/ntsync.c b/tools/testing/selftests/drivers/ntsync/ntsync.c
> index 3aad311574c4..bfb6fad653d0 100644
> --- a/tools/testing/selftests/drivers/ntsync/ntsync.c
> +++ b/tools/testing/selftests/drivers/ntsync/ntsync.c
> @@ -968,7 +968,7 @@ TEST(wake_all)
> auto_event_args.manual = false;
> auto_event_args.signaled = true;
> objs[3] = ioctl(fd, NTSYNC_IOC_CREATE_EVENT, &auto_event_args);
> - EXPECT_EQ(0, objs[3]);
> + EXPECT_LE(0, objs[3]);
>
> wait_args.timeout = get_abs_timeout(1000);
> wait_args.objs = (uintptr_t)objs;
>
Reviewed-by: Elizabeth Figura <zfigura@codeweavers.com>
next prev parent reply other threads:[~2025-03-14 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 7:14 [PATCH 0/4] ntsync: some small fixes for doc and selftests Su Hui
2025-03-14 7:14 ` [PATCH 1/4] selftests: ntsync: fix the wrong condition in wake_all Su Hui
2025-03-14 9:21 ` Dan Carpenter
2025-03-14 22:12 ` Elizabeth Figura [this message]
2025-03-14 7:14 ` [PATCH 2/4] selftests: ntsync: avoid possible overflow in 32-bit machine Su Hui
2025-03-14 22:12 ` Elizabeth Figura
2025-03-14 7:14 ` [PATCH 3/4] selftests: ntsync: update config Su Hui
2025-03-14 22:12 ` Elizabeth Figura
[not found] <00d17d6d-19c9-4431-a3ac-c0f767c533d4@nfschina.com>
2025-03-14 10:23 ` [PATCH 1/4] selftests: ntsync: fix the wrong condition in wake_all Su Hui
2025-03-14 22:13 ` Elizabeth Figura
2025-03-15 9:39 ` Dan Carpenter
2025-03-15 20:29 ` Elizabeth Figura
2025-03-17 1:33 ` Su Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3661803.LM0AJKV5NW@camazotz \
--to=zfigura@codeweavers.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=suhui@nfschina.com \
--cc=wine-devel@winehq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox