From: Reinette Chatre <reinette.chatre@intel.com>
To: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
shuah@kernel.org, skhan@linuxfoundation.org,
linux-kselftest@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
tony.luck@intel.com, babu.moger@amd.com, james.morse@arm.com,
ravi.v.shankar@intel.com, fenghua.yu@intel.com, x86@kernel.org,
LKML <linux-kernel@vger.kernel.org>,
dan.carpenter@oracle.com, dcb314@hotmail.com
Subject: Re: [PATCH V2 00/19] Miscellaneous fixes for resctrl selftests
Date: Thu, 21 May 2020 09:12:25 -0700 [thread overview]
Message-ID: <3669988f-2a76-c698-dd95-7972056353cb@intel.com> (raw)
In-Reply-To: <cover.1589835155.git.sai.praneeth.prakhya@intel.com>
Hi Sai,
On 5/18/2020 3:08 PM, Sai Praneeth Prakhya wrote:
> Fenghua Yu (1):
> selftests/resctrl: Fix missing options "-n" and "-p"
>
> Reinette Chatre (3):
> selftests/resctrl: Fix typo
> selftests/resctrl: Fix typo in help text
> selftests/resctrl: Ensure sibling CPU is not same as original CPU
>
> Sai Praneeth Prakhya (15):
> selftests/resctrl: Rename CQM test as CMT test
> selftests/resctrl: Declare global variables as extern
> selftests/resctrl: Return if resctrl file system is not supported
> selftests/resctrl: Check for resctrl mount point only if resctrl FS is
> supported
> selftests/resctrl: Use resctrl/info for feature detection
> selftests/resctrl: Fix MBA/MBM results reporting format
> selftests/resctrl: Abort running tests if not root user
> selftests/resctrl: Enable gcc checks to detect buffer overflows
> selftests/resctrl: Dynamically select buffer size for CAT test
> selftests/resctrl: Skip the test if requested resctrl feature is not
> supported
> selftests/resctrl: Change return type of umount_resctrlfs() to void
> selftests/resctrl: Umount resctrl FS only if mounted
> selftests/resctrl: Unmount resctrl FS after running all tests
> selftests/resctrl: Fix incorrect parsing of iMC counters
> selftests/resctrl: Fix checking for < 0 for unsigned values
>
> tools/testing/selftests/resctrl/Makefile | 2 +-
> tools/testing/selftests/resctrl/README | 4 +-
> tools/testing/selftests/resctrl/cache.c | 4 +-
> tools/testing/selftests/resctrl/cat_test.c | 8 +-
> .../resctrl/{cqm_test.c => cmt_test.c} | 23 +++---
> tools/testing/selftests/resctrl/mba_test.c | 23 +++---
> tools/testing/selftests/resctrl/mbm_test.c | 16 ++--
> tools/testing/selftests/resctrl/resctrl.h | 20 +++--
> .../testing/selftests/resctrl/resctrl_tests.c | 69 ++++++++++++-----
> tools/testing/selftests/resctrl/resctrl_val.c | 67 ++++++++++------
> tools/testing/selftests/resctrl/resctrlfs.c | 77 +++++++++++++------
> 11 files changed, 195 insertions(+), 118 deletions(-)
> rename tools/testing/selftests/resctrl/{cqm_test.c => cmt_test.c} (88%)
>
Thank you very much for creating these fixes. There are a few to which I
responded directly, the rest look good to me.
Reinette
next prev parent reply other threads:[~2020-05-21 16:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 22:08 [PATCH V2 00/19] Miscellaneous fixes for resctrl selftests Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 01/19] selftests/resctrl: Rename CQM test as CMT test Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 02/19] selftests/resctrl: Fix typo Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 03/19] selftests/resctrl: Fix typo in help text Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 04/19] selftests/resctrl: Declare global variables as extern Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 05/19] selftests/resctrl: Return if resctrl file system is not supported Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 06/19] selftests/resctrl: Check for resctrl mount point only if resctrl FS is supported Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 07/19] selftests/resctrl: Use resctrl/info for feature detection Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 08/19] selftests/resctrl: Ensure sibling CPU is not same as original CPU Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 09/19] selftests/resctrl: Fix missing options "-n" and "-p" Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 10/19] selftests/resctrl: Fix MBA/MBM results reporting format Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 11/19] selftests/resctrl: Abort running tests if not root user Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 12/19] selftests/resctrl: Enable gcc checks to detect buffer overflows Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 13/19] selftests/resctrl: Dynamically select buffer size for CAT test Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 14/19] selftests/resctrl: Skip the test if requested resctrl feature is not supported Sai Praneeth Prakhya
2020-05-20 23:46 ` Reinette Chatre
2020-05-21 17:12 ` Prakhya, Sai Praneeth
2020-05-18 22:08 ` [PATCH V2 15/19] selftests/resctrl: Change return type of umount_resctrlfs() to void Sai Praneeth Prakhya
2020-05-20 23:52 ` Reinette Chatre
2020-05-21 17:19 ` Prakhya, Sai Praneeth
2020-05-21 18:15 ` Reinette Chatre
2020-05-18 22:08 ` [PATCH V2 16/19] selftests/resctrl: Umount resctrl FS only if mounted Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 17/19] selftests/resctrl: Unmount resctrl FS after running all tests Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 18/19] selftests/resctrl: Fix incorrect parsing of iMC counters Sai Praneeth Prakhya
2020-05-18 22:08 ` [PATCH V2 19/19] selftests/resctrl: Fix checking for < 0 for unsigned values Sai Praneeth Prakhya
2020-05-21 16:12 ` Reinette Chatre [this message]
2020-05-21 17:28 ` [PATCH V2 00/19] Miscellaneous fixes for resctrl selftests Prakhya, Sai Praneeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3669988f-2a76-c698-dd95-7972056353cb@intel.com \
--to=reinette.chatre@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@oracle.com \
--cc=dcb314@hotmail.com \
--cc=fenghua.yu@intel.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox