From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22DF912B158 for ; Tue, 26 Mar 2024 21:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711487151; cv=none; b=YE8N40IIBjlu9sHg8oJFlBM9rXwrfBGPfrHM7ZamxIXR3DMrZwKXlFum2OLY5q8Z93LAfqV3zDm31opeBlj5OO8No/Al48c8IpKKJIXvfddbhytNr7sZxQ89c2O1KAUPRh90Qc+T/UAkQq4ZzUMQ9ZrmYZH4J1lLcQz+tn2PIV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711487151; c=relaxed/simple; bh=8/6VIqtn4FmmIolsIBNMglvOzS+Y8GYpiEzpcGwTcH4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eYdIObcUGo89S9UMQNGQPJVHE9WzuCobG1TF0XVOIOJGove5TlnMVyx7Tm1PByUEjYaH4z/y3q3VrqE5mkh8cjXgrkYvYomnn9qQp/xOJiMdUwGtzIKOhNjewcbWw0GnO9QTi3h85da/XWSJ5tUbGXqEnONl7kUT+VfNnTmYyT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cLa+U+tW; arc=none smtp.client-ip=209.85.166.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cLa+U+tW" Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-7cc5e664d52so66444239f.0 for ; Tue, 26 Mar 2024 14:05:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1711487148; x=1712091948; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yGoOwtmMdt/+f2HpwpVRuxkbr+Dx6I+/q8ycSS5E9Jc=; b=cLa+U+tWOcwWg4UzddQg69ecqLCDZpW5OW9lSzYDqVNllMMERp9XLkQwv2TN7m2zKk v/hXed+0IgtrdlnIyqTeKbO4zidZOGjN/+xa9FUc1ns/ylWgjPJ1uLxEtWwmCOq4x60G tpi6rRefFG2bMDaUp/2KNNnUpzyZVYGDeksfw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711487148; x=1712091948; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yGoOwtmMdt/+f2HpwpVRuxkbr+Dx6I+/q8ycSS5E9Jc=; b=Nph/b3hY/kQt+HN4/yXDUqvLTbimZmz+LFBF+Th/gEowzx+XfxWTQ0g0bxMOo+RwjK WoNoaK88S40j85QgllSGU8WXzjExs3dunBkjjdeNCO0MiBz5bpPiSx7b6KDuzXkHkqPO JMn4RUADv4GPK8yOmqlVigFTaFpxx37brBIen+9lxK8jpyOE/U7xwYJiWjSNfMJ7sp6n TdT0xyLQgq8QI06q0yOrnhavOu9IGBeaUFBhcfzVFuq/0RBlF1UPCRqnxjuAzcIyMOch Xwmvt5CZNMgLMi76TCnPQ63qcdf/f5xDLygjbu14pvAEO+wLjtYo76f9M3nIlZAjS1GP udkA== X-Forwarded-Encrypted: i=1; AJvYcCXESoTtmX+rnOTdA6N/o8R991RVe6i62CDNDWrGiY4u7g957qVN+hQVB9jnBS1vgOcH0XVrX+wCvuymPp6zuYg5ssZGj+6ARaiC9nrGltVp X-Gm-Message-State: AOJu0YxRbeWUOzD+DN1TdxZdOZNp0rPxZdq4Qux+FsEQjWLnNFBz+en5 LmeKeBrEKD69zPutbIkmOOuUuzALUG+uk/Z5SpALTgqiD+R8A9Tow/gpu9KcRAxtbuqZUBFYfW+ n X-Google-Smtp-Source: AGHT+IHRvTI1s4ZzDDNA894GQ739rWQ9Evl664b9P5wXeFUCpMADcnYCXFwXrUt8XMYZRnPFudkffw== X-Received: by 2002:a6b:5d16:0:b0:7d0:3f6b:6af9 with SMTP id r22-20020a6b5d16000000b007d03f6b6af9mr10144994iob.0.1711487148189; Tue, 26 Mar 2024 14:05:48 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id y8-20020a029508000000b00476e3cabd48sm1081667jah.69.2024.03.26.14.05.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 14:05:47 -0700 (PDT) Message-ID: <387a04c3-356e-4248-9cd3-7aa1a617c221@linuxfoundation.org> Date: Tue, 26 Mar 2024 15:05:47 -0600 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] selftests/dmabuf-heap: conform test to TAP format output Content-Language: en-US To: Muhammad Usama Anjum , Shuah Khan , "T.J. Mercier" Cc: kernel@collabora.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240305060848.2478806-1-usama.anjum@collabora.com> From: Shuah Khan In-Reply-To: <20240305060848.2478806-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/4/24 23:08, Muhammad Usama Anjum wrote: > Conform the layout, informational and status messages to TAP. No > functional change is intended other than the layout of output messages. > > Reviewed-by: T.J. Mercier > Signed-off-by: Muhammad Usama Anjum > --- > Changes since v4: > - close fds correctly with code changes added in v3 > > Chanages since v3: > - abort test-case instead of exiting if heap/mem allocation fails > - Correct test_alloc_zeroed() test case in case of failure > > Changes since v2: > - Minor improvements in test_alloc_zeroed() results > > Changes since v1: > - Update some more error handling code t would be nice to improve the error messages in addition to changing them over to TAP format. Please see below: > --- > .../selftests/dmabuf-heaps/dmabuf-heap.c | 246 +++++++----------- > 1 file changed, 101 insertions(+), 145 deletions(-) > > diff --git a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c > index 890a8236a8ba7..e7bd03e0af2ea 100644 > --- a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c > +++ b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include "../kselftest.h" > > #define DEVPATH "/dev/dma_heap" > > @@ -90,14 +91,13 @@ static int dmabuf_heap_open(char *name) > char buf[256]; > > ret = snprintf(buf, 256, "%s/%s", DEVPATH, name); > - if (ret < 0) { > - printf("snprintf failed!\n"); > - return ret; > - } > + if (ret < 0) > + ksft_exit_fail_msg("snprintf failed!\n"); Why not include the return value in the message? > > fd = open(buf, O_RDWR); > if (fd < 0) > - printf("open %s failed!\n", buf); > + ksft_exit_fail_msg("open %s failed: %s\n", buf, strerror(errno)); > + > return fd; > } > > @@ -140,7 +140,7 @@ static int dmabuf_sync(int fd, int start_stop) > > #define ONE_MEG (1024 * 1024) > > -static int test_alloc_and_import(char *heap_name) > +static void test_alloc_and_import(char *heap_name) > { > int heap_fd = -1, dmabuf_fd = -1, importer_fd = -1; > uint32_t handle = 0; > @@ -148,27 +148,19 @@ static int test_alloc_and_import(char *heap_name) > int ret; > > heap_fd = dmabuf_heap_open(heap_name); > - if (heap_fd < 0) > - return -1; > > - printf(" Testing allocation and importing: "); > + ksft_print_msg("Testing allocation and importing:\n"); > ret = dmabuf_heap_alloc(heap_fd, ONE_MEG, 0, &dmabuf_fd); > if (ret) { > - printf("FAIL (Allocation Failed!)\n"); > - ret = -1; > - goto out; > + ksft_test_result_fail("FAIL (Allocation Failed!)\n"); Same here/ > + return; > } > + > /* mmap and write a simple pattern */ > - p = mmap(NULL, > - ONE_MEG, > - PROT_READ | PROT_WRITE, > - MAP_SHARED, > - dmabuf_fd, > - 0); > + p = mmap(NULL, ONE_MEG, PROT_READ | PROT_WRITE, MAP_SHARED, dmabuf_fd, 0); > if (p == MAP_FAILED) { > - printf("FAIL (mmap() failed)\n"); > - ret = -1; > - goto out; > + ksft_test_result_fail("FAIL (mmap() failed)\n"); Same here and the rest of the changes in this patch. thanks, -- Shuah