From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4886D74409 for ; Fri, 5 Jul 2024 18:10:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720203023; cv=none; b=XSfZQZ2FUDWqL1Yq3uT64Fyzj3SOXzA0FjXJFYVnT4H8XVFZEdVaMO6LCuwJanSIkK5j0quqJDmOmE2qUTVnVjTwN2pYqX71Kt/K23PDdD+Wzy/I1W56yk+dR7ovHzbZ0cwsv/Di0kbZoMEz37bXxo3EE1XUFGgxOAqO6R5zyeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720203023; c=relaxed/simple; bh=7dKVWzFhqcdwTAHOJrZFlh1/32PUtLe6VOINCqyYYYQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=glEXHaJ/hGz8OpJjZ8Pm0jkymCJ//4yRrbkOFzNz8j004EY0g9zb7yraRW8XAaeJX1JUIeywmrdMFziai8b99RxcGkcgnBj06UJ6u8jSoP2MYQ012SEyq4BPAucpAUaVUV6g8+h+gEHHzz2lfGgcxfADntaYZ0HDBpxYjkmZQPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=feHjoKai; arc=none smtp.client-ip=209.85.166.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="feHjoKai" Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-38362117f6eso1386445ab.2 for ; Fri, 05 Jul 2024 11:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1720203021; x=1720807821; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gfT5A5m5TRLHFfKNa8cuOS8hGTJVflloANcGwiwozfY=; b=feHjoKaigA4hda6M8oRT38NPslkL20bqHY8XMWCMG1nP7n0degNaJDJXeqW+P7AoP9 78yy7E/q1sDgBbletxsam+lypwnGdbEQvsqkn45fZfNcu3QJ0PhdgdyEusp4RND1dG+V bxZuwMVlSwMp75+oALsrI84iramCI+Dhn+ehY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720203021; x=1720807821; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gfT5A5m5TRLHFfKNa8cuOS8hGTJVflloANcGwiwozfY=; b=iw58W7hINBi+P4iU7rybI5u7wV0VMn3/vEd/wfC8agBypkRdnzStw8mNjoA83pklBG Gb8h286L1rFArH54/9Ppg5mLjomwlZ/cJj+Fak03apdZyOBvd3UdNkQA1m3sQ0UrnX1D 7fdmKmxq+5UBEmrhvnnYXHuBtt65n+jyXJ2b/1Y0oPg47kf8WAo3KRDt3TklDp6UsS18 3QjVolqYotTKpEiFsyPs0qvcDlmrwo52Bi89wf3qWvJBjB1qvnjAYfY0YV/orNXzV9Xx m1TIZTOwSmOlNkdv22LiD/46dxPy3OaPK9x6x1hSbVS8TCz6fObWgrtlg3UGDUOLCIVO av9g== X-Forwarded-Encrypted: i=1; AJvYcCW7+EF0EaQihRrI3T6oipPosrbrMYZG2q69tAeTYtbmrpKkXtfv+100JvWSML/1OA1qvwcH5jaGrlSpYkEveCQ3UMC8Y/G6aZ/ANMuFRBYw X-Gm-Message-State: AOJu0Yzyxvt6VuwW1cnYGXt88b1870YeCDmUzOsOJo/BxMPb372u+qrk 1CZknxuAJZwnYr8iOjNQIVRWGIzez5pPEmrxcO5dISb05HqR79YaqV6pa/EM138= X-Google-Smtp-Source: AGHT+IEmjNDu/+i49etUyMQh25KpJihMcsAHI7NWFylJpgwGEGQ9bSlSjqPT+ZyYcP/4mAxoJLiM4Q== X-Received: by 2002:a05:6e02:13a9:b0:381:c5f0:20d5 with SMTP id e9e14a558f8ab-383953e23c4mr71729995ab.0.1720203021379; Fri, 05 Jul 2024 11:10:21 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-37ad2f41329sm38763435ab.50.2024.07.05.11.10.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jul 2024 11:10:20 -0700 (PDT) Message-ID: <38852b52-7ea5-431a-b946-b0dc6bb54e7d@linuxfoundation.org> Date: Fri, 5 Jul 2024 12:10:20 -0600 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] selftests/mm: remove partially duplicated "all:" target in Makefile To: John Hubbard , Shuah Khan Cc: "Jason A . Donenfeld" , Thomas Gleixner , Andy Lutomirski , Mark Brown , Vincenzo Frascino , Colin Ian King , Valentin Obst , linux-kselftest@vger.kernel.org, LKML , llvm@lists.linux.dev, Shuah Khan References: <20240704023324.83564-1-jhubbard@nvidia.com> <20240704023324.83564-3-jhubbard@nvidia.com> <9b59fc84-2d78-4304-9f39-3a495e438af8@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/5/24 11:58, John Hubbard wrote: > On 7/5/24 10:53, Shuah Khan wrote: >> On 7/3/24 20:33, John Hubbard wrote: >>> There were a couple of errors here: >>> >>> 1. TEST_GEN_PROGS was incorrectly prepending $(OUTPUT) to each program >>> to be built. However, lib.mk already does that because it assumes "bare" >>> program names are passed in, so this ended up creating >>> $(OUTPUT)/$(OUTPUT)/file.c, which of course won't work as intended. >>> >>> 2. lib.mk was included before TEST_GEN_PROGS was set, which led to >>> lib.mk's "all:" target not seeing anything to rebuild. >>> >>> So nothing worked, which caused the author to force things by creating >>> an "all:" target locally--while still including ../lib.mk. >>> >>> Fix all of this by including ../lib.mk at the right place, and removing >>> the $(OUTPUT) prefix to the programs to be built, and removing the >>> duplicate "all:" target. >>> >>> Signed-off-by: John Hubbard >> >> Why does the summary say mm ? > > This is a mistake. I was also preparing some mm work at the time, > and typed the wrong thing. > > Could you fix it up to s/mm/vDSO/ for me? Or if it's easier, I can send > an updated patch, let me know. > > Send me updated patch - it will be easier that way. I saw the note about getting these into 6.10 - As soon as you send the patch I will apply them and send them for 6.10 thanks, -- Shuah