From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <edumazet@google.com>,
<davem@davemloft.net>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>, <shuah@kernel.org>,
<linux-kselftest@vger.kernel.org>,
<willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next] selftests: net: give up on the cmsg_time accuracy on slow machines
Date: Thu, 16 Jan 2025 12:52:00 +0100 [thread overview]
Message-ID: <3c522b9c-703c-4aa0-82e3-d7f9fc8d4480@intel.com> (raw)
In-Reply-To: <20250116020105.931338-1-kuba@kernel.org>
On 1/16/25 03:01, Jakub Kicinski wrote:
> Commit b9d5f5711dd8 ("selftests: net: increase the delay for relative
> cmsg_time.sh test") widened the accepted value range 8x but we still
> see flakes (at a rate of around 7%).
you have undid the 8x change by this commit (without mentioning that)
[fine for me]
>
> Return XFAIL for the most timing sensitive test on slow machines.
code change looks fine for me, and does exactly that, so:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>
> Before:
>
> # ./cmsg_time.sh
> Case UDPv4 - TXTIME rel returned '8074us - 7397us < 4000', expected 'OK'
> FAIL - 1/36 cases failed
>
> After:
>
> # ./cmsg_time.sh
> Case UDPv4 - TXTIME rel returned '1123us - 941us < 500', expected 'OK' (XFAIL)
> Case UDPv6 - TXTIME rel returned '1227us - 776us < 500', expected 'OK' (XFAIL)
> OK
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2025-01-16 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 2:01 [PATCH net-next] selftests: net: give up on the cmsg_time accuracy on slow machines Jakub Kicinski
2025-01-16 11:52 ` Przemek Kitszel [this message]
2025-01-16 13:00 ` Willem de Bruijn
2025-01-17 12:49 ` Petr Machata
2025-01-17 14:53 ` Jakub Kicinski
2025-01-17 15:16 ` Petr Machata
2025-01-18 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c522b9c-703c-4aa0-82e3-d7f9fc8d4480@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox