From: Shuah Khan <skhan@linuxfoundation.org>
To: Ma Ke <make24@iscas.ac.cn>,
shuah@kernel.org, usama.anjum@collabora.com,
swarupkotikalapudi@gmail.com, amer.shanawany@gmail.com,
kees@kernel.org, akpm@linux-foundation.org, luto@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3] selftests/capabilities: Fix possible file leak in copy_fromat_to
Date: Tue, 2 Jul 2024 10:22:57 -0600 [thread overview]
Message-ID: <3d7e1a06-28d1-4d78-b04a-ff9cbf85aaa3@linuxfoundation.org> (raw)
In-Reply-To: <20240630130038.3671507-1-make24@iscas.ac.cn>
On 6/30/24 07:00, Ma Ke wrote:
> The open() function returns -1 on error. openat() and open() initialize
> 'from' and 'to', and only 'from' validated with 'if' statement. If the
> initialization of variable 'to' fails, we should better check the value
> of 'to' and close 'from' to avoid possible file leak. Improve the checking
> of 'from' additionally.
>
> Fixes: 32ae976ed3b5 ("selftests/capabilities: Add tests for capability evolution")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> Changes in v3:
> - Thank you for your interest in our vulnerability detection method. We
> extract vulnerability characteristics from a known vulnerability and match
> the same characteristics in the project code. As our work is still in
> progress, we are not able to disclose it at this time. Appreciate your
> understanding, we could better focus on the potential vulnerability itself.
> Reference link: https://lore.kernel.org/all/20240510003424.2016914-1-samasth.norway.ananda@oracle.com/
Sorry it is a NACK - without more details on the tool and warning,
I can't accept this patch.
thanks,
-- Shuah
prev parent reply other threads:[~2024-07-02 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 13:00 [PATCH v3] selftests/capabilities: Fix possible file leak in copy_fromat_to Ma Ke
2024-07-01 6:12 ` Muhammad Usama Anjum
2024-07-01 8:01 ` Markus Elfring
2024-07-02 16:22 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d7e1a06-28d1-4d78-b04a-ff9cbf85aaa3@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=amer.shanawany@gmail.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=make24@iscas.ac.cn \
--cc=shuah@kernel.org \
--cc=swarupkotikalapudi@gmail.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox