From: Paolo Abeni <pabeni@redhat.com>
To: MD Danish Anwar <danishanwar@ti.com>,
geliang@kernel.org, liuhangbin@gmail.com,
dan.carpenter@linaro.org, jiri@resnulli.us,
n.zhandarovich@fintech.ru, aleksander.lobakin@intel.com,
lukma@denx.de, horms@kernel.org, jan.kiszka@siemens.com,
diogo.ivo@siemens.com, shuah@kernel.org, kuba@kernel.org,
edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
srk@ti.com, Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>,
m-malladi@ti.com
Subject: Re: [PATCH net-next v2 4/4] selftests: hsr: Add test for VLAN
Date: Thu, 31 Oct 2024 15:41:43 +0100 [thread overview]
Message-ID: <3e443eb4-d15f-45ff-8b41-a8215fb4032b@redhat.com> (raw)
In-Reply-To: <20241024103056.3201071-5-danishanwar@ti.com>
On 10/24/24 12:30, MD Danish Anwar wrote:
> @@ -183,9 +232,21 @@ trap cleanup_all_ns EXIT
> setup_hsr_interfaces 0
> do_complete_ping_test
>
> +# Run VLAN Test
> +if $vlan; then
> + setup_vlan_interfaces
> + hsr_vlan_ping
> +fi
> +
> setup_ns ns1 ns2 ns3
>
> setup_hsr_interfaces 1
> do_complete_ping_test
>
> +# Run VLAN Test
> +if $vlan; then
> + setup_vlan_interfaces
> + hsr_vlan_ping
> +fi
The new tests should be enabled by default. Indeed ideally the test
script should be able to run successfully on kernel not supporting such
feature; you could cope with that looking for the hsr exposed feature
and skipping the vlan test when the relevant feature is not present.
Cheers,
Paolo
next prev parent reply other threads:[~2024-10-31 14:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 10:30 [PATCH net-next v2 0/4] Introduce VLAN support in HSR MD Danish Anwar
2024-10-24 10:30 ` [PATCH net-next v2 1/4] net: hsr: Add VLAN support MD Danish Anwar
2024-10-24 10:30 ` [PATCH net-next v2 2/4] net: hsr: Add VLAN CTAG filter support MD Danish Anwar
2024-10-24 13:36 ` Vadim Fedorenko
2024-10-24 15:10 ` Anwar, Md Danish
2024-10-31 14:37 ` Paolo Abeni
2024-11-04 11:20 ` MD Danish Anwar
2024-10-24 10:30 ` [PATCH net-next v2 3/4] net: ti: icssg-prueth: Add VLAN support for HSR mode MD Danish Anwar
2024-10-24 10:30 ` [PATCH net-next v2 4/4] selftests: hsr: Add test for VLAN MD Danish Anwar
2024-10-31 14:41 ` Paolo Abeni [this message]
2024-11-05 11:14 ` MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e443eb4-d15f-45ff-8b41-a8215fb4032b@redhat.com \
--to=pabeni@redhat.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=dan.carpenter@linaro.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=lukma@denx.de \
--cc=m-malladi@ti.com \
--cc=n.zhandarovich@fintech.ru \
--cc=netdev@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=shuah@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox