From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E76C43334 for ; Tue, 26 Jul 2022 05:00:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231828AbiGZFAC (ORCPT ); Tue, 26 Jul 2022 01:00:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230410AbiGZFAB (ORCPT ); Tue, 26 Jul 2022 01:00:01 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBE2225E9C; Mon, 25 Jul 2022 21:59:59 -0700 (PDT) Received: from [192.168.10.7] (unknown [39.45.217.167]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 5651C6601ABA; Tue, 26 Jul 2022 05:59:56 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658811598; bh=L4t37Vh3jZkgSuCdQPGk9mApZh53ColnkjMa6i8Qb68=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=eqpjeqYxlAPc5AoTQZXTUqlIpEuQ+UvjJV67tlcfCWqSyuCamZgkls6FuYUmAeXWp CEjq4Z4Ri+MLI2rJks8bd9H6ROa89Vy9XDMvao+SLZUgfK+8/mldVCWcsq8O+6dJ2j 3Cf5XxZoOYQ0nxfHgC1pyRNUjdCzRB06ZhOSutfPOACkQ/drfGMrYPQqBs+UYZ7jBd ARTaFVCJezIlwJScBly7s3aMHoJf2lBP6ZomrZYEGDrlOXZUipuv3OFiEehvkLB1li GbKnUu6KYKMt1SLGcxUl/Q3kAQC7jtk+DFUoiyFng7brgzVvckUdIXxuXeqGNpkdQJ 4z0/fauR/b0SQ== Message-ID: <3e48da77-68b3-e94a-b428-2e628ca1d46b@collabora.com> Date: Tue, 26 Jul 2022 09:59:51 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: usama.anjum@collabora.com, kernel@collabora.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] docs/kselftest: Fix build commands in guidelines Content-Language: en-US To: Shuah Khan , Shuah Khan , Jonathan Corbet References: <20220704083426.1867401-1-usama.anjum@collabora.com> <58aad5c5-339f-85b9-8f48-0ffbd133b0cb@linuxfoundation.org> From: Muhammad Usama Anjum In-Reply-To: <58aad5c5-339f-85b9-8f48-0ffbd133b0cb@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 7/8/22 9:51 PM, Shuah Khan wrote: > On 7/4/22 2:34 AM, Muhammad Usama Anjum wrote: >> Build commands start with "make". It is missing. Add "make" to the start >> of the build command. >> >> Fixes: 820636106342 ("docs/kselftest: add more guidelines for adding >> new tests") >> Signed-off-by: Muhammad Usama Anjum >> --- >>   Documentation/dev-tools/kselftest.rst | 6 +++--- >>   1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/dev-tools/kselftest.rst >> b/Documentation/dev-tools/kselftest.rst >> index ee6467ca8293..9dd94c334f05 100644 >> --- a/Documentation/dev-tools/kselftest.rst >> +++ b/Documentation/dev-tools/kselftest.rst >> @@ -255,9 +255,9 @@ Contributing new tests (details) >>      * All changes should pass:: >>   -    kselftest-{all,install,clean,gen_tar} >> -    kselftest-{all,install,clean,gen_tar} O=abo_path >> -    kselftest-{all,install,clean,gen_tar} O=rel_path >> +    make kselftest-{all,install,clean,gen_tar} >> +    make kselftest-{all,install,clean,gen_tar} O=abs_path >> +    make kselftest-{all,install,clean,gen_tar} O=rel_path >>       make -C tools/testing/selftests {all,install,clean,gen_tar} >>       make -C tools/testing/selftests {all,install,clean,gen_tar} >> O=abs_path >>       make -C tools/testing/selftests {all,install,clean,gen_tar} >> O=rel_path >> > > Looks like it depends on a patch already in doc tree? Yes, the dependent patch is in doc tree. Corbet should pick up this patch. > Acked-by: Shuah Khan > > thanks, > -- Shuah -- Muhammad Usama Anjum