From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B77C57E762; Wed, 7 Feb 2024 14:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707317155; cv=none; b=VeDST8GXxaJuegYvNW19YDBVZv5nIJmcLt8da4bFlW2c9RiN3N53R4iWlxwiXcS76EwW9SuD/88gF7VPfLKd04OCwMJi8hxSrH21BT95RDZo4/ofTm6kdgzNCYqhe0DkhyKyhetnDOstXKih5J7+DaLHxN6FpJzQM4KnMCCVyaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707317155; c=relaxed/simple; bh=zIvVw9zalejYZpIXWcUgEcCzc6VUMVHZ64fUR3dLlEk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P3zNLNvzUCPah1pgpDzvUolnb1YoIbnu+Qo8yQfdXFtp35WUcg5j1LLWaGO7V2RI1WnZhKWGHPRJWpNZs/RR/JWUn3gTzzUEsB42vDWQ0g1RBxVsu6rRyQmZPQd15BSh17aflFr7bNTHXjJ6kYjnWzmj03zZxlT4xU4CfuTv/Jo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QSNB8DNs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QSNB8DNs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16D45C433F1; Wed, 7 Feb 2024 14:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707317155; bh=zIvVw9zalejYZpIXWcUgEcCzc6VUMVHZ64fUR3dLlEk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QSNB8DNs9LVW9ZsU9XD7MGX5kjjaqNnjEHHYCZ1c7SI/6H33gC2bXg0DZq4GppfRw rS4vk8/cvr8y4m4wl+6cDT0wBPjrD7FEvhrOHHef2bcl0F8WtQUYe6kdLIw3kbZ7h1 9zXK7fa+cqnZ4n7+PVnHmJW9f3bDjMVJRFOAIBdIIY4UPbHvXsS668fLGfNsv+GITF PEnfrGevaEKYv1X6wj/+VQ2HKrhs8IDQqcKQP5J7PCXMoA6nd9WdEwWNdi5soAa+iu P3lo4avqtCkKtTaJUXX6D4h4hX9vL6j7FUY1dZ9K2ZE2I2C2TrNUu1AV7VmtQYsxe+ lw5fSA7jYXOqw== Message-ID: <3e5f9040-53a4-4906-819a-ef38500f9eb6@kernel.org> Date: Wed, 7 Feb 2024 15:45:44 +0100 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] selftests: net: cope with slow env in gro.sh test Content-Language: en-GB, fr-BE To: Paolo Abeni Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Shuah Khan , Willem de Bruijn , Coco Li , linux-kselftest@vger.kernel.org, netdev@vger.kernel.org References: <117a20b1b09addb804b27167fafe1a47bfb2b18e.1707233152.git.pabeni@redhat.com> <794b684b8d7b0cecb59c403bd14877426facc5f4.camel@redhat.com> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <794b684b8d7b0cecb59c403bd14877426facc5f4.camel@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Paolo, On 07/02/2024 15:35, Paolo Abeni wrote: > On Wed, 2024-02-07 at 12:16 +0100, Matthieu Baerts wrote: >> Hi Paolo, >> >> On 06/02/2024 16:27, Paolo Abeni wrote: >>> The gro self-tests sends the packets to be aggregated with >>> multiple write operations. >>> >>> When running is slow environment, it's hard to guarantee that >>> the GRO engine will wait for the last packet in an intended >>> train. >>> >>> The above causes almost deterministic failures in our CI for >>> the 'large' test-case. >>> >>> Address the issue explicitly ignoring failures for such case >>> in slow environments (KSFT_MACHINE_SLOW==true). >> >> To what value is KSFT_MACHINE_SLOW set in the CI? > > AFAIK, the CI initialize KSFT_MACHINE_SLOW (to true) only on slow env. Should be good, then! >> Is it set to a different value if the machine is not slow? e.g. >> >> KSFT_MACHINE_SLOW == false >> >> (please see below) >> >>> Fixes: 7d1575014a63 ("selftests/net: GRO coalesce test") >>> Signed-off-by: Paolo Abeni >>> --- >>> Note that the fixes tag is there mainly to justify targeting the net >>> tree, and this is aiming at net to hopefully make the test more stable >>> ASAP for both trees. >>> >>> I experimented with a largish refactory replacing the multiple writes >>> with a single GSO packet, but exhausted by time budget before reaching >>> any good result. >>> --- >>> tools/testing/selftests/net/gro.sh | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/tools/testing/selftests/net/gro.sh b/tools/testing/selftests/net/gro.sh >>> index 19352f106c1d..114b5281a3f5 100755 >>> --- a/tools/testing/selftests/net/gro.sh >>> +++ b/tools/testing/selftests/net/gro.sh >>> @@ -31,6 +31,10 @@ run_test() { >>> 1>>log.txt >>> wait "${server_pid}" >>> exit_code=$? >>> + if [ ${test} == "large" -a -n "${KSFT_MACHINE_SLOW}" ]; then >> >> Maybe best to avoid using: >> >> -n "${KSFT_MACHINE_SLOW}" >> >> Otherwise, we have the same behaviour if KSFT_MACHINE_SLOW is set to >> 1/yes/true or 0/no/false. > > For consistency, I followed the logic already in place in commit > c41dfb0dfbec ("selftests/net: ignore timing errors in so_txtime if > KSFT_MACHINE_SLOW"). I only checked code in -net, I forgot to look at net-next. Thanks for the pointer! I thought it was "fragile", but if that's how we are supposed to use this env var, that's OK then :) >> But maybe it is fine like that, and what is just missing is adding >> somewhere how KSFT_MACHINE_SLOW is supposed to be set/used? :) >> >> >> Not linked to that, but a small detail about the new line, just in case >> you need to send a v2: it looks like it is better to avoid using '-a': >> >> https://www.shellcheck.net/wiki/SC2166 > > Thank for the pointer, I was not aware of that. > > I guess a v2 dropping '-a' would be better. I'm not even sure a v2 is really needed. "-a" seems OK if you don't use (or don't plan to use) "!" or "-" in the expression from what I read. Another way to fix this is to use [[ ]]: [[ ${test} == "large" && -n "${KSFT_MACHINE_SLOW}" ]] Cheers, Matt -- Sponsored by the NGI0 Core fund.