From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C0F13254AD for ; Thu, 16 Oct 2025 09:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760605353; cv=none; b=a58Nz5dfK2aJkEs0D7YK+twSBH9uSia0px0Rv2zLyBCc3yt9xNuKl+/c6iaiNnx1Wa3oLmkWSKDeRFCqEmXfHvr43rn3lbRF4OnPZ56NToMFIbG0cL4qO5e9tty1k2OywlPqQHdzDoxk2N31cDkPpkJwcdFx8UhAX87GKLq9KQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760605353; c=relaxed/simple; bh=+AtvyGqwUgALdVZc2SXcYDz/237PjQqovYd5Z7PxSbA=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=RBIy2ReXZGMxhHoNXuKqy8IydaL39qJGhPWWEhE6nUO3RxVRn79qlR60p46gtEdiJ6v7VOXyFtgCuVLVH+MzPo2KfXlGOnQLVJ8qYW9doN903/gowEWgxDX29fX/ZyIQS2kYdRkYehYTYupDr6+MEFwvlCW7pKqQUu+4QkX0ItE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aNUMwv3z; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aNUMwv3z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760605350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5GQfxStX9qdjnF8aD6SOVhJPa/g/zUO8yOqhMVk2ON4=; b=aNUMwv3zp4/Vi9b6p02yAGuucYNzZt5nohfETo/eSAtJZi41sYpZkKyvmXXWlbEEUWvJDF EOFhhdgtuVujtKMft8Ut72fBuhcNTHHzBsG4VWXlTlm/UCxZentH04KxxOUhX2l1E9PD0E Cr8SYgalPQRgIhgfisUmq3OH/sArDE0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-604-JF2U8XhuOsiTtm1qABfnZg-1; Thu, 16 Oct 2025 05:02:29 -0400 X-MC-Unique: JF2U8XhuOsiTtm1qABfnZg-1 X-Mimecast-MFC-AGG-ID: JF2U8XhuOsiTtm1qABfnZg_1760605348 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47108163eeaso2104345e9.3 for ; Thu, 16 Oct 2025 02:02:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760605348; x=1761210148; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5GQfxStX9qdjnF8aD6SOVhJPa/g/zUO8yOqhMVk2ON4=; b=IOTSUur/uImG4CDrqDGEUbe7KmSPgao/TJHVqv0MuG9N5DwDzNA49lWCEKOb+83cN6 F0TP9ttq2zj3mJCivBGSkUnGvIkQ9EXUHB3cVmwvhdjHr8mSkr3wRGlg+EvxqIEF3r0v xt5zTEcJlTybRNOuaAjdsGDZwQVRcWArT2HiU5jTEu8S58EZUVvhF70wcLD7Tle41jGp UQks7yLRjE75uoezmID80WHPKZwzYnyCUUjqR6vsHSqGL3zC3i1axibCYcvqVZeUosoN 30M+JrJ2q2aG6WPiR2+iGAuBEkGkJdJ8JnQkzaeFs64I3w232JEU/ON/ncpegezpXUy7 fhEg== X-Forwarded-Encrypted: i=1; AJvYcCX9SigEqpWmcjahiZT7spGx85FwFANuTMinKMTmlejYvbC/s+alT3jSD0LAkErixYocFMq9c/qtW6rBexqh8Gc=@vger.kernel.org X-Gm-Message-State: AOJu0YxwAVCc50XfOhdMQIBiB4Twlw88hVdhf/1ULV8oFDAkJGp0qK+S zSN2sXeqzd3BFHAuQqD8Jr9gvDBRWX1+/XgK41KutS/LA5QE7SFf+A8VyffLzzVk1N9n1BtjwXS w3c/KI7Oq7mWQildEOgcpJGjz/cDmPQ1NYY2/WSKIT+m+aBST66fu1aAAYoOn3PYTT2KAoQ== X-Gm-Gg: ASbGncuNwun5ctOouDdMMydj/AJh20Hgpf4fTPYja6ORtNIn23SX62aUa27TxtEC0T+ zKdsaGoyk7aEoIfv3Nx43CUzRtTPPqFleKJwSB9ijCCA8LSBjyyRKXIFiwAwkGsC9GbfB+yn65+ DG08mqKYqBfvzV11tbITrsCGJI+VInDqZldKrRXq7uiuSp+0mmeSTLkiSNC86TkIyB5haFQxeWh c+8Vxo9yUcXzVb0ox1CjPzPsKBLL57tnpoJbctzKxncqPd6Cg5hroC6x9TtZDcx+5AenSZslabt 8l/d4sIHfA6NKUp67I5TqqlLBxZ1iEJacetbL3ScFfr1jgE9K9rIvss/p6OQy1KBvp33YXNAJn6 k/aoHkhOmtL5lJW6UA27+TVqR4gDm/sC2yo74FM+qMzeMnDI= X-Received: by 2002:a05:600c:3b08:b0:456:1b6f:c888 with SMTP id 5b1f17b1804b1-46fa9af364bmr194084425e9.23.1760605348010; Thu, 16 Oct 2025 02:02:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBKaKCixlap2LGsrCQoy/ztjbrbjTMc5FWNVc5/WkapPDjvhhGgdyb9Tum59RrTjzgqDuQQw== X-Received: by 2002:a05:600c:3b08:b0:456:1b6f:c888 with SMTP id 5b1f17b1804b1-46fa9af364bmr194083915e9.23.1760605347524; Thu, 16 Oct 2025 02:02:27 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2712:7e10:4d59:d956:544f:d65c? ([2a0d:3344:2712:7e10:4d59:d956:544f:d65c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4711444e3fesm14977005e9.15.2025.10.16.02.02.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Oct 2025 02:02:26 -0700 (PDT) Message-ID: <4042d1da-a7aa-46c4-87c5-736d74d280a2@redhat.com> Date: Thu, 16 Oct 2025 11:02:22 +0200 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 net-next 05/13] tcp: accecn: handle unexpected AccECN negotiation feedback To: chia-yu.chang@nokia-bell-labs.com, edumazet@google.com, linux-doc@vger.kernel.org, corbet@lwn.net, horms@kernel.org, dsahern@kernel.org, kuniyu@amazon.com, bpf@vger.kernel.org, netdev@vger.kernel.org, dave.taht@gmail.com, jhs@mojatatu.com, kuba@kernel.org, stephen@networkplumber.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net, liuhangbin@gmail.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, ij@kernel.org, ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com, g.white@cablelabs.com, ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com, cheshire@apple.com, rs.ietf@gmx.at, Jason_Livingood@comcast.com, vidhi_goel@apple.com References: <20251013170331.63539-1-chia-yu.chang@nokia-bell-labs.com> <20251013170331.63539-6-chia-yu.chang@nokia-bell-labs.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251013170331.63539-6-chia-yu.chang@nokia-bell-labs.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/13/25 7:03 PM, chia-yu.chang@nokia-bell-labs.com wrote: > From: Chia-Yu Chang > > According to Section 3.1.2 of AccECN spec (RFC9768), if a TCP Client > has sent a SYN requesting AccECN feedback with (AE,CWR,ECE) = (1,1,1) > then receives a SYN/ACK with the currently reserved combination > (AE,CWR,ECE) = (1,0,1) but it does not have logic specific to such a > combination, the Client MUST enable AccECN mode as if the SYN/ACK > confirmed that the Server supported AccECN and as if it fed back that > the IP-ECN field on the SYN had arrived unchanged. > > This patch fix an incorrect AccECN negoation of commit 3cae34274c79 > ("tcp: accecn: AccECN negotiation"). Minor nit: with my previous feedback I asked a formal fixes tag here. Yes, we can have fixes tag on net-next. No need to re-submit just for this. /P