From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA9AC35E04 for ; Tue, 25 Feb 2020 14:54:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E43AE218AC for ; Tue, 25 Feb 2020 14:54:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=isovalent-com.20150623.gappssmtp.com header.i=@isovalent-com.20150623.gappssmtp.com header.b="jGWepyEI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730922AbgBYOyr (ORCPT ); Tue, 25 Feb 2020 09:54:47 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35179 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730646AbgBYOyr (ORCPT ); Tue, 25 Feb 2020 09:54:47 -0500 Received: by mail-wr1-f66.google.com with SMTP id w12so15095484wrt.2 for ; Tue, 25 Feb 2020 06:54:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=y++kI/5dCtw5fZaeSgXh8lWKMSaGQmRYxWkHHDDsYEE=; b=jGWepyEIkZ1p0tED+rauWwmW4k3RG+6zN0X4+Bky/2ByebPFpB9k5sL2WKPs6Odb+c E5MFAI285mX4zdtjqORrRKQDBBJwXm1myO7nslK+AtFUxk5GUzxOs1R8v73pHgKaV2X0 7R/bLi/0hyOhShc0bz1uYhtozSNWxm0TGVRbDAkkvl0P/UQ1ljuyPwdVM1Nj0jSzRkLz hmkndN0H37fZzshO4I7DzEGHOxlvrPfvsAt9p7Naj81CWN4vKqrl+nuY6mZlh+N4Rj07 7gnDQ/sDjdKgaWRUy/RfRO+i8ZglHkuBPTxsb18n4eB0SPCdfQsiuh1wa857P0BP4fUo TgIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y++kI/5dCtw5fZaeSgXh8lWKMSaGQmRYxWkHHDDsYEE=; b=FUb3/RI6dldZYtXzw4TY9gULX9QKQqAMGVmx50/EzekvvkQ6Sl6fhYXOJzlXLEbxJv DMY7hHW3lXQZgWCw0TXbp6LS3pUfurg2rOrNPlrhrdYtDHvSEH0uoPqHTr4ZCDSiFg+Y 9WVNDPV21vf+EcY7rRkBxU2Pq0Z5V7OOweH6zM8njCIO0+lRWplXnYj9q1ICgNjWzSxb NkWcNGD+jMrrTmogONn0RxL9lKCPPvxXwz51Ol67wt1dm2Uo0QNpli7YYGRIn3AXGlIi keGlxyk9BJwQQoNxg2blLHRIA2S/jkTX/wPi++kxW/L8N/g5ICOL49FXnz8f5VdBW43q a2HA== X-Gm-Message-State: APjAAAVMLYOuFivbg0xsegB2MSfyFj6x67uaIRx4HCvp2aRR+YaD7MIi 7hVFapnTHamUAB6MIAr7leZy63m7i/Y= X-Google-Smtp-Source: APXvYqwfSaJ8pCA6BhtoWHv0t8xFZnZrK/CzrI1X29nZWXWlh6LSoOIjxsxgH2SsHYgerYZIkRUP+w== X-Received: by 2002:adf:f244:: with SMTP id b4mr20457380wrp.413.1582642485266; Tue, 25 Feb 2020 06:54:45 -0800 (PST) Received: from [192.168.1.10] ([194.35.116.65]) by smtp.gmail.com with ESMTPSA id v131sm4674454wme.23.2020.02.25.06.54.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2020 06:54:44 -0800 (PST) Subject: Re: [PATCH bpf-next v2 5/5] selftests/bpf: Add test for "bpftool feature" command To: Michal Rostecki , bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , "David S. Miller" , Jesper Dangaard Brouer , John Fastabend , "open list:KERNEL SELFTEST FRAMEWORK" References: <20200221031702.25292-1-mrostecki@opensuse.org> <20200221031702.25292-6-mrostecki@opensuse.org> From: Quentin Monnet Message-ID: <424b3804-a6ec-750c-bc90-753bbdf512ce@isovalent.com> Date: Tue, 25 Feb 2020 14:54:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org 2020-02-25 14:55 UTC+0100 ~ Michal Rostecki > On 2/21/20 12:28 PM, Quentin Monnet wrote: >>> +    @default_iface >>> +    def test_feature_dev(self, iface): >>> +        expected_patterns = [ >>> +            SECTION_SYSCALL_CONFIG_PATTERN, >>> +            SECTION_PROGRAM_TYPES_PATTERN, >>> +            SECTION_MAP_TYPES_PATTERN, >>> +            SECTION_HELPERS_PATTERN, >>> +            SECTION_MISC_PATTERN, >>> +        ] >> >> Mixed feeling on the tests with plain output, as we keep telling people >> that plain output should not be parsed (not reliable, may change). But >> if you want to run one or two tests with it, why not, I guess. > > I thought about that and yes, testing the plain output is probably > redundant and makes those tests less readable. However, the only plain > output test which I would like to keep there is test_feature_macros - > because I guess that we are not planning to change names or patterns of > generated macros (or if so, we should test that change). > I did not mentally include the header/macros output in “plain output”, but yeah I guess I was not explicit on this one. So: Agreed, with “macros” it should not change and it is welcome in the tests, feel free to keep it :) Quentin