From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82035C4338F for ; Mon, 23 Aug 2021 20:29:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6019B613E8 for ; Mon, 23 Aug 2021 20:29:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232331AbhHWUa0 (ORCPT ); Mon, 23 Aug 2021 16:30:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231569AbhHWUaZ (ORCPT ); Mon, 23 Aug 2021 16:30:25 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB042C061575 for ; Mon, 23 Aug 2021 13:29:42 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id b200so23461443iof.13 for ; Mon, 23 Aug 2021 13:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jrb8MmGaC68emddPwQPjXM1GY7GuBgRkSODpa1XojoA=; b=Jix95rVYPKxFfYL/aPT0sbEErQFG61rQbSUAEgNs/qK+fLsttL42hCyXs3hCp5CV0R rsX0/JQ+9CLBWK5wOGmo8fqZW/0iI/q+zzd1IrZBKMm0G27kGdG5UyrDI7/mtfbYoBCE nWdejcd7DXz4DhU5ADMGa0i1ys42I2y/8956E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jrb8MmGaC68emddPwQPjXM1GY7GuBgRkSODpa1XojoA=; b=DGilRJ8euT8V5Qph/i1pjUlhHQf2aaQ4JI/6/INc0RzvFg1mcOrHxYEJ0kboa3ppDw 8NpWmezV3NhjmrA7mhKlorBK8kOKjQT81+aSN1fB3e9fgLRf5ZkzRNmpqpxThMjyT+UW qPfct5g7YO6VGOZOX2konCd1cpFTubD4iwd1o8Ymr/7Ev6TPWfKyVV2kk0YGhoZBwm8K 0jxAHwxsnaVmo9UukFRuyQjNigTwMbjrjbPbg9u2btu7YPtqwdboFXQchOQfAaNa7rYP jdkegp+AOk5/IHzLvdWhbqPLbl+wZfgJ1vdd8yqZK3nLHdj2MmaiXJBbjQmOJH9RnEm5 PQWw== X-Gm-Message-State: AOAM531xCdUFfv+vT1aDYZcYlFS7+VunI/4hmRn3bom9/lak8IRU0+k0 Ft65NZGbwTMf8CNSTqfLijIJ/w== X-Google-Smtp-Source: ABdhPJxy1IRPOXexnqBhdOFJX0C6Doap9TfWg7EDkycAW0RxoKdX1OxZ1jB+j6JRstZSIPeYJNiV9g== X-Received: by 2002:a05:6602:2ac7:: with SMTP id m7mr28422332iov.66.1629750582194; Mon, 23 Aug 2021 13:29:42 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id y12sm8635418ilm.81.2021.08.23.13.29.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Aug 2021 13:29:41 -0700 (PDT) Subject: Re: [V2][PATCH] selftests/x86: Fix error: variably modified 'altstack_data' at file scope To: Jun Miao , shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20210823135626.3926364-1-jun.miao@windriver.com> From: Shuah Khan Message-ID: <437f8945-cbd9-dccd-2d86-bd6746d1424c@linuxfoundation.org> Date: Mon, 23 Aug 2021 14:29:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210823135626.3926364-1-jun.miao@windriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 8/23/21 7:56 AM, Jun Miao wrote: > Based on glibc 2.33 -> 2.34, there is one new feature: > > NEWS for version 2.34 > ===================== > Major new features: > * Add _SC_MINSIGSTKSZ and _SC_SIGSTKSZ. When _DYNAMIC_STACK_SIZE_SOURCE > or _GNU_SOURCE are defined, MINSIGSTKSZ and SIGSTKSZ are no longer > constant on Linux. MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) > and SIGSTKSZ is redefined to sysconf (_SC_SIGSTKSZ). This supports > dynamic sized register sets for modern architectural features like > Arm SVE. > > Build error with the GNU C Library 2.34: > DEBUG: | sigreturn.c:150:13: error: variably modified 'altstack_data' at file scope > | sigreturn.c:150:13: error: variably modified 'altstack_data' at file scope > DEBUG: | 150 | static char altstack_data[SIGSTKSZ]; > | 150 | static char altstack_data[SIGSTKSZ]; > DEBUG: | | ^~~~~~~~~~~~~ > Please give more context on why this change is needed? Doesn't look like you tried to compile this patch before sending this to me. > Signed-off-by: Jun Miao thanks, -- Shuah