From: Dave Hansen <dave.hansen@intel.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
shuah@kernel.org, hpa@zytor.com, x86@kernel.org,
dave.hansen@linux.intel.com, bp@alien8.de, mingo@redhat.com,
tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kirill@shutemov.name,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v5 3/3] selftests/lam: Test get_user() LAM pointer handling
Date: Fri, 24 Jan 2025 08:32:18 -0800 [thread overview]
Message-ID: <44743729-02f8-4c73-b6c3-9a1ca7dd28cd@intel.com> (raw)
In-Reply-To: <df3790293723dff0b020deb4863828389eb41060.1732728879.git.maciej.wieczor-retman@intel.com>
On 11/27/24 09:35, Maciej Wieczor-Retman wrote:
...
> + switch (test->later) {
> + case GET_USER_USER:
> + /* Control group - properly tagger user pointer */
> + ptr = (void *)set_metadata((uint64_t)ptr, test->lam);
> + break;
s/tagger/tagged/ ?
> + default:
> + printf("Invalid test case value passed!\n");
> + break;
> + }
> +
> + if (ioctl(fd, FIOASYNC, ptr) != 0)
> + ret = 1;
> +
> + close(fd);
> +error:
> + munmap(ptr, PAGE_SIZE);
> + return ret;
> +}
I'd really prefer that the theory of operation be in a code comment and
not just in the changelog.
next prev parent reply other threads:[~2025-01-24 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 17:35 [PATCH v5 0/3] selftests/lam: get_user additions and LAM enabled check Maciej Wieczor-Retman
2024-11-27 17:35 ` [PATCH v5 1/3] selftests/lam: Move cpu_has_la57() to use cpuinfo flag Maciej Wieczor-Retman
2025-01-24 16:14 ` Dave Hansen
2025-01-24 20:17 ` Maciej Wieczor-Retman
2025-01-24 20:24 ` Dave Hansen
2025-01-24 20:29 ` Maciej Wieczor-Retman
2024-11-27 17:35 ` [PATCH v5 2/3] selftests/lam: Skip test if LAM is disabled Maciej Wieczor-Retman
2025-01-24 16:23 ` Dave Hansen
2025-01-24 20:09 ` Maciej Wieczor-Retman
2024-11-27 17:35 ` [PATCH v5 3/3] selftests/lam: Test get_user() LAM pointer handling Maciej Wieczor-Retman
2025-01-24 16:32 ` Dave Hansen [this message]
2025-01-24 20:19 ` Maciej Wieczor-Retman
2025-01-15 9:06 ` [PATCH v5 0/3] selftests/lam: get_user additions and LAM enabled check Maciej Wieczor-Retman
2025-01-23 21:52 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44743729-02f8-4c73-b6c3-9a1ca7dd28cd@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=mingo@redhat.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox