From: Shuah Khan <skhan@linuxfoundation.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Anders Roxell <anders.roxell@linaro.org>
Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com,
shuah@kernel.org, rust-for-linux@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 1/2] selftests: rust: config: add trailing newline
Date: Sun, 11 Aug 2024 17:36:50 -0600 [thread overview]
Message-ID: <4542b8cb-414c-49e3-8509-6975976ce3a6@linuxfoundation.org> (raw)
In-Reply-To: <CANiq72kM1RsZCrK-3gFZufgeZQRvOBAbO=DwRHpukX5W=T=UAg@mail.gmail.com>
On 8/10/24 04:33, Miguel Ojeda wrote:
> On Fri, Aug 2, 2024 at 2:45 PM Anders Roxell <anders.roxell@linaro.org> wrote:
>>
>> If adding multiple config files to the merge_config.sh script and
>> rust/config is the fist one, then the last config fragment in this file
>> and the first config fragment in the second file wont be set, since
>> there isn't a newline in this file, so those two fragements end up at
>> the same row like:
>> CONFIG_SAMPLE_RUST_PRINT=mCONFIG_FRAGMENT=y
>>
>> And non of those will be enabled when running 'olddefconfig' after.
>>
>> Fixing the issue by adding a newline to the file.
>
> Could `merge_config.sh` be improved too?
>
> Shuah, if you plan to pick this:
>
> Acked-by: Miguel Ojeda <ojeda@kernel.org>
>
> Thanks!
>
> Cheers,
> Miguel
Applied to linux-kselftest next for Linux 6.12-rc1.
thanks,
-- Shuah
prev parent reply other threads:[~2024-08-11 23:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 12:45 [PATCH 1/2] selftests: rust: config: add trailing newline Anders Roxell
2024-08-02 12:45 ` [PATCH 2/2] selftests: rust: config: disable GCC_PLUGINS Anders Roxell
2024-08-10 10:34 ` Miguel Ojeda
2024-08-11 23:35 ` Shuah Khan
2024-08-10 10:33 ` [PATCH 1/2] selftests: rust: config: add trailing newline Miguel Ojeda
2024-08-11 23:36 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4542b8cb-414c-49e3-8509-6975976ce3a6@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=alex.gaynor@gmail.com \
--cc=anders.roxell@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox