From: Reinette Chatre <reinette.chatre@intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-kselftest@vger.kernel.org, "Shuah Khan" <shuah@kernel.org>,
"Maciej Wieczór-Retman" <maciej.wieczor-retman@intel.com>,
"Babu Moger" <babu.moger@amd.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>, <linux-kernel@vger.kernel.org>,
"Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH v6 15/16] selftests/resctrl: Remove mongrp from CMT test
Date: Fri, 7 Jun 2024 11:16:24 -0700 [thread overview]
Message-ID: <45758766-f3f6-455d-ba34-36b9fbad80cb@intel.com> (raw)
In-Reply-To: <20240607125316.7089-16-ilpo.jarvinen@linux.intel.com>
Hi Ilpo,
On 6/7/24 5:53 AM, Ilpo Järvinen wrote:
> The CMT selftest instantiates a monitor group to read LLC occupancy.
> Since the test also creates a control group, it is unnecessary to
> create another one for monitoring because control groups already
> provide monitoring too.
>
> Remove the unnecessary monitor group from the CMT selftest.
>
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Tested-by: Babu Moger <babu.moger@amd.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> --
"--" -> "---" to prevent snippet below from being included in
changelog.
Reinette
next prev parent reply other threads:[~2024-06-07 18:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 12:53 [PATCH v6 00/16] selftests/resctrl: resctrl_val() related cleanups & improvements Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 01/16] selftests/resctrl: Fix closing IMC fds on error and open-code R+W instead of loops Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 02/16] selftests/resctrl: Calculate resctrl FS derived mem bw over sleep(1) only Ilpo Järvinen
2024-06-07 17:54 ` Reinette Chatre
2024-06-10 14:55 ` Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 03/16] selftests/resctrl: Make "bandwidth" consistent in comments & prints Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 04/16] selftests/resctrl: Consolidate get_domain_id() into resctrl_val() Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 05/16] selftests/resctrl: Use correct type for pids Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 06/16] selftests/resctrl: Cleanup bm_pid and ppid usage & limit scope Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 07/16] selftests/resctrl: Rename measure_vals() to measure_mem_bw_vals() & document Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 08/16] selftests/resctrl: Simplify mem bandwidth file code for MBA & MBM tests Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 09/16] selftests/resctrl: Add ->measure() callback to resctrl_val_param Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 10/16] selftests/resctrl: Add ->init() callback into resctrl_val_param Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 11/16] selftests/resctrl: Simplify bandwidth report type handling Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 12/16] selftests/resctrl: Make some strings passed to resctrlfs functions const Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 13/16] selftests/resctrl: Convert ctrlgrp & mongrp to pointers Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 14/16] selftests/resctrl: Remove mongrp from MBA test Ilpo Järvinen
2024-06-07 12:53 ` [PATCH v6 15/16] selftests/resctrl: Remove mongrp from CMT test Ilpo Järvinen
2024-06-07 18:16 ` Reinette Chatre [this message]
2024-06-07 12:53 ` [PATCH v6 16/16] selftests/resctrl: Remove test name comparing from write_bm_pid_to_resctrl() Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45758766-f3f6-455d-ba34-36b9fbad80cb@intel.com \
--to=reinette.chatre@intel.com \
--cc=babu.moger@amd.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox