From: Nimrod Oren <noren@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org,
willemb@google.com, petrm@nvidia.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] selftests: drv-net: split up gro.py
Date: Tue, 1 Sep 2026 09:45:19 +0300 [thread overview]
Message-ID: <4804ad0f-ff5d-4b74-8285-9595c0c6732d@nvidia.com> (raw)
In-Reply-To: <20260831163734.1121891-1-kuba@kernel.org>
On 31/08/2026 19:37, Jakub Kicinski wrote:
> gro.py runs its full set of cases three times over - against SW GRO,
> HW GRO and LRO. It's our test with the longest runtime. The 318 cases
> take 12m30s on mlx5 with a debug kernel.
>
> We will likely add more subcases here as the time goes on, so it's
> time to start splitting it up. Long runtime wastes time on retries
> (if any of the 300+ cases fails we try to check if it's a real failure
> or flake an re-run the whole thing). It also forces us to increase
> timeout for the whole test suite.
>
> Jakub Kicinski (3):
> selftests: drv-net: hw: rename gro_hw.py to gro_stats.py
> selftests: drv-net: split gro.py into one test per coalescing mode
> selftests: drv-net: bump the timeout to 15min
>
> tools/testing/selftests/drivers/net/Makefile | 9 ++-
> .../testing/selftests/drivers/net/hw/Makefile | 2 +-
> tools/testing/selftests/drivers/net/gro_hw.py | 14 ++++
> .../drivers/net/{gro.py => gro_lib.py} | 68 +++++++++----------
> .../testing/selftests/drivers/net/gro_lro.py | 15 ++++
> tools/testing/selftests/drivers/net/gro_sw.py | 14 ++++
> .../net/hw/{gro_hw.py => gro_stats.py} | 0
> .../selftests/drivers/net/pppoe_gro.py | 46 +++++++++++++
> tools/testing/selftests/drivers/net/settings | 2 +-
> .../selftests/net/lib/ksft_setup_loopback.sh | 2 +-
> 10 files changed, 131 insertions(+), 41 deletions(-)
> create mode 100755 tools/testing/selftests/drivers/net/gro_hw.py
> rename tools/testing/selftests/drivers/net/{gro.py => gro_lib.py} (92%)
> mode change 100755 => 100644
> create mode 100755 tools/testing/selftests/drivers/net/gro_lro.py
> create mode 100755 tools/testing/selftests/drivers/net/gro_sw.py
> rename tools/testing/selftests/drivers/net/hw/{gro_hw.py => gro_stats.py} (100%)
> create mode 100755 tools/testing/selftests/drivers/net/pppoe_gro.py
>
For the series:
Reviewed-by: Nimrod Oren <noren@nvidia.com>
next prev parent reply other threads:[~2026-09-01 6:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 16:37 [PATCH net-next 0/3] selftests: drv-net: split up gro.py Jakub Kicinski
2026-08-31 16:37 ` [PATCH net-next 1/3] selftests: drv-net: hw: rename gro_hw.py to gro_stats.py Jakub Kicinski
2026-08-31 19:52 ` Joe Damato
2026-08-31 16:37 ` [PATCH net-next 2/3] selftests: drv-net: split gro.py into one test per coalescing mode Jakub Kicinski
2026-09-01 15:34 ` Joe Damato
2026-09-01 19:44 ` Jakub Kicinski
2026-08-31 16:37 ` [PATCH net-next 3/3] selftests: drv-net: bump the timeout to 15min Jakub Kicinski
2026-09-01 15:35 ` Joe Damato
2026-09-01 6:45 ` Nimrod Oren [this message]
2026-09-01 14:07 ` [PATCH net-next 0/3] selftests: drv-net: split up gro.py Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4804ad0f-ff5d-4b74-8285-9595c0c6732d@nvidia.com \
--to=noren@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox