From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B2D8C433DF for ; Thu, 28 May 2020 19:09:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A082206A1 for ; Thu, 28 May 2020 19:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590692951; bh=roOklKRbpl70gT9R9STMxF97juiDvHKA90cXs9507x4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=OCFv+eb+lGQeGajVf7ldAU1lvblmWvwQjJndcKY5tkUvECtwKe147txWxXBp2pSNm Jfh8XW2fwxytWTPIgba6uCT7UMt3KqFeHiNpUFeUh6sQG6D03v04LLNLWHzAFl9b43 ChmKmVcOx7+qzmWwrHrYkVk2uqE08mv2Pq1LCtxs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406148AbgE1TJK (ORCPT ); Thu, 28 May 2020 15:09:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406140AbgE1TJI (ORCPT ); Thu, 28 May 2020 15:09:08 -0400 Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D453C08C5C6 for ; Thu, 28 May 2020 12:09:08 -0700 (PDT) Received: by mail-oi1-x244.google.com with SMTP id 23so169418oiq.8 for ; Thu, 28 May 2020 12:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=R1miPeFxlEwY+xa1vHbyy5ZFTUIV4sByz1KFasPvaMo=; b=J/w44VXcuQwVzhDejQed3zs4vp1LHMgN7CuoIIpC+RzHwUC0pojnD40cPYLaT3gRTw uhIUxj+WX5IA8XU3NY3RTwC6uonE3JI6oExue/f4VgCSRXaCI/xnEgh/qvhYXxiCjpW5 pTpDC5NrnfhRTiVnDHhB91P2s73OCZpNMv2Ek= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=R1miPeFxlEwY+xa1vHbyy5ZFTUIV4sByz1KFasPvaMo=; b=ofJBfr5g3YakJ4APlC2TfCWwsvAnCn1LBfRAVTpYjxRnrqJf/mtY0E4uli+znVPp2w 1SLiLvaqrCFV2j3GBPBp6VBEEtj2bPFebJpIRndrqCxiZ/WjxZiUUB5Wu46AuMtq6GOL CHob/1fzZbsZQRngC+xNW1DSErDkSTtEgj6c7JtPzFvTvelF9CREsyjAZizbnsBl5BPS f4pvQ7wnV3vLHLSsamY44/oed0wgvNNzGRus3E2y6YrJGSWDbKiiSlJ3sfnOHX+/kmjf +hJyxwaILbEakYBc7IUSxfgY5vL7QmqOeG4F8TRl++B/6vDxChcXiAy9+dqOISCIZ/0c zvPw== X-Gm-Message-State: AOAM5338ZSOLXls96jWlALVeYsQkAJ219fKZmAjuMeIg+uoG329vky0d Jr6it9eG8TF6LLvaBM1VLWDDkw== X-Google-Smtp-Source: ABdhPJzeIeUYkycKOmuIkrTdoApQA1unywU2tyzVI1+rxsL25gai5MwSGXcFgSO/d+YuLo7Ym04KcA== X-Received: by 2002:aca:5202:: with SMTP id g2mr3386666oib.80.1590692947211; Thu, 28 May 2020 12:09:07 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id v10sm1593704oov.15.2020.05.28.12.09.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2020 12:09:06 -0700 (PDT) Subject: Re: [PATCH] selftests/bpf: split -extras target to -static and -gen To: Yauheni Kaliuta , Alexei Starovoitov Cc: Greg KH , Jiri Benc , shuah , Andrii Nakryiko , bpf , Jiri Olsa , Andrii Nakryiko , Daniel Borkmann , "open list:KERNEL SELFTEST FRAMEWORK" , skhan@linuxfoundation.org References: <20200528100557.20489f04@redhat.com> <20200528105631.GE3115014@kroah.com> <20200528161437.x3e2ddxmj6nlhvv7@ast-mbp.dhcp.thefacebook.com> From: Shuah Khan Message-ID: <49931ed9-da92-4b32-ba54-aeba33166bdd@linuxfoundation.org> Date: Thu, 28 May 2020 13:09:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 5/28/20 11:10 AM, Yauheni Kaliuta wrote: > Hi, Alexei, > > On Thu, May 28, 2020 at 7:14 PM Alexei Starovoitov > wrote: >> >> On Thu, May 28, 2020 at 12:56:31PM +0200, Greg KH wrote: >>> On Thu, May 28, 2020 at 10:05:57AM +0200, Jiri Benc wrote: >>>> On Wed, 27 May 2020 15:23:13 -0700, Alexei Starovoitov wrote: >>>>> I prefer to keep selftests/bpf install broken. >>>>> This forced marriage between kselftests and selftests/bpf >>>>> never worked well. I think it's a time to free them up from each other. >>>> >>>> Alexei, it would be great if you could cooperate with other people >>>> instead of pushing your own way. The selftests infrastructure was put >>>> to the kernel to have one place for testing. Inventing yet another way >>>> to add tests does not help anyone. You don't own the kernel. We're >>>> community, we should cooperate. >>> >>> I agree, we rely on the infrastructure of the kselftests framework so >>> that testing systems do not have to create "custom" frameworks to handle >>> all of the individual variants that could easily crop up here. >>> >>> Let's keep it easy for people to run and use these tests, to not do so >>> is to ensure that they are not used, which is the exact opposite goal of >>> creating tests. >> >> Greg, >> >> It is easy for people (bpf developers) to run and use the tests. >> Every developer runs them before submitting patches. >> New tests is a hard requirement for any new features. >> Maintainers run them for every push. >> >> What I was and will push back hard is when other people (not bpf developers) >> come back with an excuse that some CI system has a hard time running these >> tests. It's the problem of weak CI. That CI needs to be fixed. Not the tests. >> The example of this is that we already have github/libbpf CI that runs >> selftests/bpf just fine. Anyone who wants to do another CI are welcome to copy >> paste what already works instead of burdening people (bpf developers) who run >> and use existing tests. I frankly have no sympathy to folks who put their own >> interest of their CI development in front of bpf community of developers. >> The main job of CI is to help developers and maintainers. >> Where helping means to not impose new dumb rules on developers because CI >> framework is dumb. Fix CI instead. >> > > Any good reason why bpf selftests, residing under selftests/, should > be an exception? > "Breakages" is not, breakages are fixable. > Let's not talk about moving tests. I don't want to discuss that until we are all on the same page on what is the problem in adding install support to bpf Makefile. It is possible that there is a misunderstanding that bpf maintainer and developer workflow will change. Which is definitely not needed. If this patch series requires it, it isn't correct and needs to be reworked. thanks, -- Shuah