From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 586B93FB2F for ; Mon, 15 Apr 2024 09:31:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713173475; cv=none; b=OMXjE/7AyDVv/kJLP1sW9hxw1P2F6JpwD9Winc2tHzVVI4lGPJNJ8tKZbLyr3dHA3Ggj4Q5wTs/Y1zxRPujAvM7NfobEjuspQwqGcdRekPrjL4QZHp848+s/9GQ34C9RVmGTsrwReJyWAsX1jhtJlJAA+cSdgpu0x3bCUJr7SuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713173475; c=relaxed/simple; bh=2IlEm+cS9qj+vvfLyV47lTngsYPf2mmY4pM3HORgXKA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=oMs5D43c+BlURQKWAJrBQ118kBopu63RPkdCZRZ1Mh2M2Mr59+MK6gXMk+JNjnqexIYcKPUHVSSXW02Vf9wI49YKHA5zsiZfskf5h/T8BOEYbkpDnJbP+UhTu52LZDoNKcGxqHsKwac18+YuakGdC4M8MqgxQVCuvUrZj4YtBTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ePKbY/ad; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ePKbY/ad" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713173473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Hmvte7MCJ3AOLHNPnXbtBprQ3NZn8ExlHHzgFo7EW0M=; b=ePKbY/admGTOh/c/3gOlxr6kBxfQ1S9kMJiJFOKBhZ+fpUQOnt+q+Rqica9pxc+nmVMi4Q vwGUGjeNHYq/tUlhttF1+VQALeahOngWigm17DhTHgg/hZEDqKoBphdIFao2R3jVOj3flU 7Fb+gZmGadTx3pKctIoS0KnacBOkp+w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-3kG1aY0vMpmPGUWXr3tl-A-1; Mon, 15 Apr 2024 05:31:08 -0400 X-MC-Unique: 3kG1aY0vMpmPGUWXr3tl-A-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-416a207b107so6994395e9.0 for ; Mon, 15 Apr 2024 02:31:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713173467; x=1713778267; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hmvte7MCJ3AOLHNPnXbtBprQ3NZn8ExlHHzgFo7EW0M=; b=vy6yApo+K4S5Xu8CKrghHea1e36lYx3VNm53b0fcuaDJVwD/mGZcN0g6vt8n39boBa I8C+ih+hW8wdWAxmWL2ZXz/doQ/rTDw+0gsNHQj3dTvNUqhW9haQl6gNgTU5Ymr1TNWb lvoUbzs+Tg5w1YA0KqtNl6XKo8IYk9symtwhMOtiLOV/iQKPJ9DwzMbUpEYo+hWSkWxv GNbxUjElMJQG74YoiZ0Q1TkDR1DRorhIQXy5z+BOtnSvRjx+IzRgw1haxqppg4ZVhKDl NlQLtl50Y5uUMcU/majj8+e7d9lp4StHpeva5nPea4KrVIYe+TNHfuknek1LUwEUPklY 9MzQ== X-Forwarded-Encrypted: i=1; AJvYcCXKKZ1N1v1xCvvshzQ3kWiJWDmmMzLhNI7ipFpAZHl6HEAHUEAipUePUCWq1g3p664r0XKZFg7JTUvSsdluEZ9v9iciKYIBRvJqPhyxwXK7 X-Gm-Message-State: AOJu0YyVOZ6wMtlR+Fa3ykUwWg83KfQb5x333fC7/F+l5iJ/9sF/VKqC uqa0w6HD6v3BDvyLDgDvNqDNeb+2UdPio3E/AMVIZ2dIeHtQ9W2DK/CAx7iZegUe/LUYeOEOvgS WhiLva6EQ4ii79DHe4dEVh3+6KLXzHPOE2Qzc0URnMiY6GfXuW9SEla5S3+9AvROecg== X-Received: by 2002:a05:600c:474a:b0:416:80b1:6a31 with SMTP id w10-20020a05600c474a00b0041680b16a31mr7239962wmo.0.1713173467495; Mon, 15 Apr 2024 02:31:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHRBXxbwL/NffFNCU4mu4WJ1E+JcgzFfdk5hzV7oNUO5+BoDA+pXZko5YRFjAhu1IKYqMB5Rg== X-Received: by 2002:a05:600c:474a:b0:416:80b1:6a31 with SMTP id w10-20020a05600c474a00b0041680b16a31mr7239947wmo.0.1713173467109; Mon, 15 Apr 2024 02:31:07 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-228-238.dyn.eolo.it. [146.241.228.238]) by smtp.gmail.com with ESMTPSA id fc18-20020a05600c525200b0041563096e15sm18875879wmb.5.2024.04.15.02.31.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 02:31:06 -0700 (PDT) Message-ID: <49deeded3764fd43b9af23f2f6e1b8f4ab599910.camel@redhat.com> Subject: Re: [PATCH net-next 5/5] selftests: drv-net: add a trivial ping test From: Paolo Abeni To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, shuah@kernel.org, petrm@nvidia.com, linux-kselftest@vger.kernel.org, willemb@google.com Date: Mon, 15 Apr 2024 11:31:05 +0200 In-Reply-To: <20240412233705.1066444-6-kuba@kernel.org> References: <20240412233705.1066444-1-kuba@kernel.org> <20240412233705.1066444-6-kuba@kernel.org> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2024-04-12 at 16:37 -0700, Jakub Kicinski wrote: > +def ping_v4(cfg) -> None: > + if not cfg.v4: > + raise KsftXfailEx() > + > + cmd(f"ping -c 1 -W0.5 {cfg.ep_v4}") > + cmd(f"ping -c 1 -W0.5 {cfg.v4}", host=3Dcfg.endpoint) Very minor nit, I personally find a bit more readable: cfg.endpoint.cmd() Which is already supported by the current infra, right? With both endpoint possibly remote could be: cfg.ep1.cmd() cfg.ep2.cmd() Thanks! Paolo