From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE14FC6FA82 for ; Tue, 13 Sep 2022 09:02:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231232AbiIMJCl (ORCPT ); Tue, 13 Sep 2022 05:02:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231592AbiIMJCI (ORCPT ); Tue, 13 Sep 2022 05:02:08 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25FA95C955; Tue, 13 Sep 2022 02:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663059700; x=1694595700; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=MQLvPvSmi5l1/oQ588bxZkJ8HGx1AWb6oknroVfrx08=; b=itfQsbOjPORrhRUFn1PasTqK5kkjPE9rUspVsNTmoBeyX8gaDhIh21kC c5a3Sh7zlWPXt5zhpVrUGM0x860aicRu/GLhBhbWKa2/ofGrTbSKTvHTm SNbPsWIJFABn7fZopyRcnM+PVl34a9w2/8uxPaix9bLUdFBHLlvr8mCUY ZlvrmuVZ14apAcv1Um2UsfS3uITQd2Ie6fa1PrqrQgD4JM8n8lk3nH1XT Dp+zfYiCOm79y7mn3y00hBecsVSJvhCOD07rMsX8WstXq0NFFkOu7fEIb p3O23TD/TYwSRroqaYfL6aDXOwnKOjhRSXlMwcNxFyMRgvlAt0GItHFSW w==; X-IronPort-AV: E=McAfee;i="6500,9779,10468"; a="362036070" X-IronPort-AV: E=Sophos;i="5.93,312,1654585200"; d="scan'208";a="362036070" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2022 02:01:39 -0700 X-IronPort-AV: E=Sophos;i="5.93,312,1654585200"; d="scan'208";a="616384388" Received: from bsalunkh-mobl.ger.corp.intel.com (HELO [10.213.238.99]) ([10.213.238.99]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2022 02:01:35 -0700 Message-ID: <4a4ed638-d505-6f30-bf0f-a16a32d494a4@intel.com> Date: Tue, 13 Sep 2022 02:01:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v13 1/3] x86/tdx: Add TDX Guest attestation interface driver Content-Language: en-US To: Sathyanarayanan Kuppuswamy , "Huang, Kai" , "tglx@linutronix.de" , "mingo@redhat.com" , "shuah@kernel.org" , "x86@kernel.org" , "bp@alien8.de" , "dave.hansen@linux.intel.com" Cc: "linux-kernel@vger.kernel.org" , "ak@linux.intel.com" , "gregkh@linuxfoundation.org" , "wander@redhat.com" , "tim.gardner@canonical.com" , "hpa@zytor.com" , "isaku.yamahata@gmail.com" , "kirill.shutemov@linux.intel.com" , "Luck, Tony" , "khalid.elmously@canonical.com" , "marcelo.cerri@canonical.com" , "Cox, Philip" , "linux-doc@vger.kernel.org" , "linux-kselftest@vger.kernel.org" References: <20220909192708.1113126-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220909192708.1113126-2-sathyanarayanan.kuppuswamy@linux.intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 9/12/22 19:44, Sathyanarayanan Kuppuswamy wrote: >> and include the header ( ?) for memchr_inv()? > One of the previous headers includes linux/string.h (I am not sure which one). > So why include it explicitly? Because it's a best practice. What happens is that you ride along on the coat tails of another #include, someone sees that include is no longer used and removes it. Then, your code is busted on some weird .config. *OR*, the header itself changes and doesn't #include the dependency you need. I guess you can go add this advice to Documentation/ if it's not there already somewhere.