Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Alexander Shatalin <sashatalin03@gmail.com>,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] fix(script): improve safety and formatting for WRITES_STRICT restore
Date: Mon, 28 Apr 2025 14:52:48 -0600	[thread overview]
Message-ID: <4ab0a88e-672f-4ffd-8642-53159f942355@linuxfoundation.org> (raw)
In-Reply-To: <CAKWAyW=nV1CNh4Pv3Uj00djOmxynBJpbSseZkTjMvcxTbE0j1g@mail.gmail.com>

On 4/23/25 02:32, Alexander Shatalin wrote:
> From: Alexander Shatalin <sashatalin03@gmail.com <mailto:sashatalin03@gmail.com>>
> 
> This patch improves the safety when restoring WRITES_STRICT by ensuring:
> - The variable is not empty (`-n`)
> - The target file is writable (`-w`)
> Also improves formatting by quoting variables and following shell best practices.
> 
> Signed-off-by: Alexander Shatalin <sashatalin03@gmail.com <mailto:sashatalin03@gmail.com>>

No attachments please. Send a proper patch with correct short log
and change log.

Check submitting patches documentation for details.

thanks,
-- Shuah

      reply	other threads:[~2025-04-28 20:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23  8:32 [PATCH] fix(script): improve safety and formatting for WRITES_STRICT restore Alexander Shatalin
2025-04-28 20:52 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ab0a88e-672f-4ffd-8642-53159f942355@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=sashatalin03@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox