Re: [PATCH v2] arm64: vdso: Fix ABI regression in compat vdso

Vincenzo Frascino
2019-07-10T15:54:04Z

Hi John,

On 10/07/2019 16:44, John Stultz wrote:
> On Wed, Jul 10, 2019 at 7:01 AM Vincenzo Frascino
> <vincenzo.frascino@arm.com> wrote:
>>
>> Prior to the introduction of Unified vDSO support and compat layer for
>> vDSO on arm64, AT_SYSINFO_EHDR was not defined for compat tasks.
>> In the current implementation, AT_SYSINFO_EHDR is defined even if the
>> compat vdso layer is not built and this causes a regression in the
>> expected behavior of the ABI.
>>
>> Restore the ABI behavior making sure that AT_SYSINFO_EHDR for compat
>> tasks is defined only when CONFIG_COMPAT_VDSO is enabled.
>>
>> Reported-by: John Stultz <john.stultz@linaro.org>
>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>
> This seems to solve it for me!
> Thanks so much for the quick turnaround on a fix. I really appreciate it!
>
> Tested-by: John Stultz <john.stultz@linaro.org>
>

Thank you for the quick reply, it means I can go home early today ;-)

> thanks
> -john
>

--
Regards,
Vincenzo