Re: [PATCH] selftests/arm64: Fix build warnings for abi

[Dev Jain <dev.jain@arm.com>]

On 8/28/24 16:10, Mark Brown wrote:
> On Tue, Aug 27, 2024 at 10:48:51AM +0530, Dev Jain wrote:
>
>> -		ksft_exit_fail_msg("PTRACE_TRACEME", strerror(errno));
>> +		ksft_exit_fail_perror("PTRACE_TRACEME");
>>   
>>   	if (raise(SIGSTOP))
>> -		ksft_exit_fail_msg("raise(SIGSTOP)", strerror(errno));
>> +		ksft_exit_fail_perror("raise(SIGSTOP)");
> The idea with these is to include the error code as well so adding the
> %s would be better.

ksft_exit_fail_perror() can do that thing for us.

>
>>   	for (i = 9; i < ARRAY_SIZE(gpr_in); i++) {
>>   		if (gpr_in[i] != gpr_out[i]) {
>> -			ksft_print_msg("%s SVE VL %d mismatch in GPR %d: %llx != %llx\n",
>> +			ksft_print_msg("%s SVE VL %d mismatch in GPR %d: %lx != %lx\n",
>>   				       cfg->name, sve_vl, i,
>>   				       gpr_in[i], gpr_out[i]);
>>   			errors++;
> This is a different pattern of warning, it'd be easier to review if each
> patch only followed one pattern.  There's no code overlap between the
> changes.