Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Brendan Higgins <brendan.higgins@linux.dev>,
	David Gow <david@davidgow.net>, Rae Moar <raemoar63@gmail.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	kunit-dev@googlegroups.com
Subject: Re: [PATCH 4/4] kunit: qemu_configs: Add microblaze configuration
Date: Wed, 2 Sep 2026 12:44:05 +0200	[thread overview]
Message-ID: <5304cc2a-5ef3-4b18-a02f-6cb051640b16@amd.com> (raw)
In-Reply-To: <b48fee3e-d113-4551-aed4-100a089e33b5@t-8ch.de>



On 9/1/26 20:33, Thomas Weißschuh wrote:
> On 2026-09-01 15:33:11+0200, Michal Simek wrote:
>> On 8/31/26 17:43, Thomas Weißschuh wrote:
>>> On 2026-08-31 12:48:08+0200, Michal Simek wrote:
> 
> (...)
> 
>>>> If there is an issue with memmove implementation I can't see any issue to
>>>> disable that options to let it pass from the beginning and solve it
>>>> separately.
>>>
>>> Ack. Could you take care of this? I have next to no idea about microblaze.
>>
>> On little endian this is passing. I can add it to my todo list but big
>> endian is very very old and likely none is using it anymore.
> 
> If it is not supposed to work maybe mark it as BROKEN or disable the
> custom memmove() implementation there and instead rely on the generic
> one from lib/string.c?

This should be enough. Do you want to send a patch for it?

diff --git a/arch/microblaze/Kconfig.platform b/arch/microblaze/Kconfig.platform
index 9cf9007ed69a..2d7c21767215 100644
--- a/arch/microblaze/Kconfig.platform
+++ b/arch/microblaze/Kconfig.platform
@@ -10,6 +10,7 @@ menu "Platform options"
  config OPT_LIB_FUNCTION
         bool "Optimized lib function"
         default y
+       depends on CPU_BIG_ENDIAN
         help
           Turns on optimized library functions (memcpy and memmove).
           They are optimized by using word alignment. This will work
@@ -21,7 +22,6 @@ config OPT_LIB_FUNCTION
  config OPT_LIB_ASM
         bool "Optimized lib function ASM"
         depends on OPT_LIB_FUNCTION && (XILINX_MICROBLAZE0_USE_BARREL = 1)
-       depends on CPU_BIG_ENDIAN
         default n
         help
           Turns on optimized library functions (memcpy and memmove).


>>>
>>>> This should be fragment for Little endian.
>>>
>>> Thanks, unfortunately this hangs for me with my distros QEMU 11.1.0.
>>> No output, 100% CPU usage during boot. I am using qemu-system-microblaze
>>> instead of qemu-system-microblazel, as the latter is not available
>>> anymore, but the former is documented to also handle little endian
>>> automatically.
>>>
>>
>> I built the latest qemu like this
>>
>> ../qemu/configure --target-list=microblaze-softmmu,microblaze-linux-user,microblazeel-linux-user
>> --enable-gcrypt --disable-docs
>>
>> /mnt/projects/xilinx-new-git/qemu.org/build-microblaze/qemu-system-microblaze
>> --version
>> QEMU emulator version 11.1.50 (v11.1.0-779-gd2e570cc0f97)
> 
> For me it still doesn't work. I am using the same build of QEMU and GCC
> 13.4.0 (or 16.2.0) from crosstools.kernel.org.

I am not a toolchain expert. I do use toolchains from Xilinx design tools and I 
have also tried toolchains from buildroot.

Linux version 7.3.0-rc1-00017-g139833dc9bf4 (monstr@monstr-desktop3) 
(microblazeel-buildroot-linux-uclibc-gcc.br_real (Buildroot 
2026.08-rc3-13-geaf7a45ddfdc) 15.3.0, GNU ld (GNU Binutils) 2.45.1) #1 Wed Sep 
2 12:39:02 CEST 2026

But keep in mind that there is a need to have v15.3.0 or 16.2.0 toolchain fixed 
by this
https://lore.kernel.org/all/20260902040121.1583600-1-neal.frager@amd.com/

Thanks,
Michal


  reply	other threads:[~2026-09-02 10:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04  5:32 [PATCH 0/4] microblaze: KUnit support Thomas Weißschuh
2026-08-04  5:32 ` [PATCH 1/4] microblaze: uaccess: Zero out destination on failed get_user() Thomas Weißschuh
2026-08-05 13:59   ` David Gow
2026-08-04  5:32 ` [PATCH 2/4] microblaze: reset: Call POWER_OFF handlers Thomas Weißschuh
2026-08-05 13:59   ` David Gow
2026-08-31  8:13   ` Michal Simek
2026-08-31 15:39     ` Thomas Weißschuh
2026-08-04  5:32 ` [PATCH 3/4] microblaze: reset: Provide a power off handler through an unaligned PC Thomas Weißschuh
2026-08-05 13:59   ` David Gow
2026-08-04  5:32 ` [PATCH 4/4] kunit: qemu_configs: Add microblaze configuration Thomas Weißschuh
2026-08-05 13:59   ` David Gow
2026-08-05 19:18     ` Thomas Weißschuh
2026-08-31  8:15       ` Michal Simek
2026-08-31 10:48   ` Michal Simek
2026-08-31 15:43     ` Thomas Weißschuh
2026-09-01 13:33       ` Michal Simek
2026-09-01 18:33         ` Thomas Weißschuh
2026-09-02 10:44           ` Michal Simek [this message]
2026-08-31 12:57 ` [PATCH 0/4] microblaze: KUnit support Michal Simek
2026-08-31 15:45   ` Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5304cc2a-5ef3-4b18-a02f-6cb051640b16@amd.com \
    --to=michal.simek@amd.com \
    --cc=brendan.higgins@linux.dev \
    --cc=david@davidgow.net \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=raemoar63@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox