From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E16C433F5 for ; Thu, 3 Mar 2022 18:18:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234555AbiCCSTT (ORCPT ); Thu, 3 Mar 2022 13:19:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233953AbiCCSTS (ORCPT ); Thu, 3 Mar 2022 13:19:18 -0500 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E187163051 for ; Thu, 3 Mar 2022 10:18:32 -0800 (PST) Received: by mail-io1-xd32.google.com with SMTP id r7so6820799iot.3 for ; Thu, 03 Mar 2022 10:18:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Qoi6ItmO2LV8AUzGFrcy7hVeYD1z9lvvPYjP0GHp6Qs=; b=MKdL+DwtJZlpBY9IPZzyPWW7YPS7kUVrIxXphWMXykUXqb0MuQG94lCGUMu+M0iNx6 QQgGdzvrO14SU0yA8tyNzi6910SnuvG2urkHO8CcTDybn31maTD94OhtHQX/CxbRkdEl a9xqDaskgXZhC/QjqIZdmrx/yRaHkNRiIgNXc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Qoi6ItmO2LV8AUzGFrcy7hVeYD1z9lvvPYjP0GHp6Qs=; b=KYG6bxdR9aEH7cffPBmeoTUvxlB8XgSCLS/Py7gTFGgG6jbd8e8oyDclBgB+d1MyYO l+DFTm4oiOoIh3/BWE6C9pLzzGLH+3jVs82waCMVLlq1JtHPbKEQraeAHYZkESdv55b0 KUsq00GK2ztrpV96/cFIE3P4tWWiqisRBZY/Q4g0vUDdMQt0CvDdGIrSmJAAq8a61dvF GGl74uQsZiZke3DlBTvior2nJqjHYu7H/n0iCZ2yXx7hGCYswqZBB+zIgg6tWJydF+KL g9cZXYyVpOr2pR3BUxVV9A39DthtinIgyDO3O44ds4Oh+MAwrWFlzmNmcka0l6L3hZBQ MaFw== X-Gm-Message-State: AOAM531g2w+QSsmyHMI6jVzmYWvdg1b8KDKlrcSQD2Yzqp0UFLvkCDdy Y+RJ20jwHXgY7ojaQ1kqL3983w== X-Google-Smtp-Source: ABdhPJxF7tc/lrJWo3NxoFRUe0jbUT/o6CtvK2W+PyXY5eaMTg9Oeswmgq0pNLka+N6TSaGCC5jlTg== X-Received: by 2002:a05:6602:2f0b:b0:644:c875:116b with SMTP id q11-20020a0566022f0b00b00644c875116bmr19583051iow.115.1646331511197; Thu, 03 Mar 2022 10:18:31 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id m1-20020a0566022ac100b00644bad95365sm2956415iov.39.2022.03.03.10.18.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 10:18:30 -0800 (PST) Subject: Re: [PATCH V3] selftests: vm: Add test for Soft-Dirty PTE bit To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, kernelci@groups.io, Will Deacon , Gabriel Krisman Bertazi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20220224212335.3045905-1-usama.anjum@collabora.com> <52f17759-c7b9-c13b-2c58-f9f2656d26f6@collabora.com> From: Shuah Khan Message-ID: <537c7ca4-6dde-cbb8-2c44-271acf96666d@linuxfoundation.org> Date: Thu, 3 Mar 2022 11:18:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <52f17759-c7b9-c13b-2c58-f9f2656d26f6@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 2/27/22 11:55 PM, Muhammad Usama Anjum wrote: > Hi, > > Andrew had already accepted the patch. I'll send an iteration. > > On 2/26/22 5:35 AM, Shuah Khan wrote: >>> +#define PAGEMAP_PATH        "/proc/self/pagemap" >> >> Why is this names PATH - it is the file name right? > I'll update the names of the macros. > >>> + >>> +int clear_refs; >>> +int pagemap; >>> + >> >> Get rid of these globals and pass these in - please find name >> that clearly indicates them as fds >> > I'll update their names to indicate fds. This is a standalone test > application. Shouldn't the usage of global variables be fine? > It makes it harder to maintain. Unless there is reason, avoid globals. I am not seeing a need for globals in this case, other than convenience. thanks, -- Shuah