From mboxrd@z Thu Jan 1 00:00:00 1970 From: dave.hansen at intel.com (Dave Hansen) Date: Fri, 16 Mar 2018 15:24:28 -0700 Subject: [PATCH v12 14/22] selftests/vm: clear the bits in shadow reg when a pkey is freed. In-Reply-To: <1519264541-7621-15-git-send-email-linuxram@us.ibm.com> References: <1519264541-7621-1-git-send-email-linuxram@us.ibm.com> <1519264541-7621-15-git-send-email-linuxram@us.ibm.com> Message-ID: <5622aacf-adc6-e547-8f36-9a43f830c29b@intel.com> On 02/21/2018 05:55 PM, Ram Pai wrote: > diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c > index c4c73e6..e82bd88 100644 > --- a/tools/testing/selftests/vm/protection_keys.c > +++ b/tools/testing/selftests/vm/protection_keys.c > @@ -586,7 +586,8 @@ int sys_pkey_free(unsigned long pkey) > int ret = syscall(SYS_pkey_free, pkey); > > if (!ret) > - shadow_pkey_reg &= reset_bits(pkey, PKEY_DISABLE_ACCESS); > + shadow_pkey_reg &= reset_bits(pkey, > + PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE); > dprintf1("%s(pkey=%ld) syscall ret: %d\n", __func__, pkey, ret); > return ret; > } What about your EXEC bit? -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: dave.hansen@intel.com (Dave Hansen) Date: Fri, 16 Mar 2018 15:24:28 -0700 Subject: [PATCH v12 14/22] selftests/vm: clear the bits in shadow reg when a pkey is freed. In-Reply-To: <1519264541-7621-15-git-send-email-linuxram@us.ibm.com> References: <1519264541-7621-1-git-send-email-linuxram@us.ibm.com> <1519264541-7621-15-git-send-email-linuxram@us.ibm.com> Message-ID: <5622aacf-adc6-e547-8f36-9a43f830c29b@intel.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20180316222428.ph-0IT4j8ExVU40ZydS2UuxPlo7MpmGf32zjP9kx67k@z> On 02/21/2018 05:55 PM, Ram Pai wrote: > diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c > index c4c73e6..e82bd88 100644 > --- a/tools/testing/selftests/vm/protection_keys.c > +++ b/tools/testing/selftests/vm/protection_keys.c > @@ -586,7 +586,8 @@ int sys_pkey_free(unsigned long pkey) > int ret = syscall(SYS_pkey_free, pkey); > > if (!ret) > - shadow_pkey_reg &= reset_bits(pkey, PKEY_DISABLE_ACCESS); > + shadow_pkey_reg &= reset_bits(pkey, > + PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE); > dprintf1("%s(pkey=%ld) syscall ret: %d\n", __func__, pkey, ret); > return ret; > } What about your EXEC bit? -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html