Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
	linux-kselftest@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Shuah Khan <shuah@kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/tracing: Test only toplevel README file not the instances
Date: Thu, 23 Jan 2025 14:56:55 -0700	[thread overview]
Message-ID: <571133ce-b4ae-4a9f-8601-443774804d1e@linuxfoundation.org> (raw)
In-Reply-To: <20250115202607.00c6d353@gandalf.local.home>

On 1/15/25 18:26, Steven Rostedt wrote:
> On Wed, 15 Jan 2025 19:17:58 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
>> From: Steven Rostedt <rostedt@goodmis.org>
>>
>> For the tests that have both a README attribute as well as the instance
>> flag to run the tests as an instance, the instance version will always
>> exit with UNSUPPORTED. That's because the instance directory does not
>> contain a README file. Currently, the tests check for a README file in the
>> directory that the test runs in and if there's a requirement for something
>> to be present in the README file, it will not find it, as the instance
>> directory doesn't have it.
>>
>> Have the tests check if the current directory is an instance directory,
>> and if it is, check two directories above the current directory for the
>> README file:
>>
>>    /sys/kernel/tracing/README
>>    /sys/kernel/tracing/instances/foo/../../README
> 
> This is the same patch as:
> 
>    https://lore.kernel.org/all/20250116012041.326701057@goodmis.org/
> 
> But as there are other patches that depended on it, I just added this one
> into a patch set with them. But decided not to make that patch set a v2 as
> there was no changes with this one.
> 
> Damn, I forgot to add Shuah and kselftests mailing list to that one though :-p
> 

Do I need to do anything or is this taken care of?

thanks,
-- Shuah

  reply	other threads:[~2025-01-23 21:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16  0:17 [PATCH] selftests/tracing: Test only toplevel README file not the instances Steven Rostedt
2025-01-16  1:26 ` Steven Rostedt
2025-01-23 21:56   ` Shuah Khan [this message]
2025-01-23 22:25     ` Steven Rostedt
2025-01-23 23:54       ` Shuah Khan
2025-02-20 16:18         ` Shuah Khan
2025-02-20 17:38           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571133ce-b4ae-4a9f-8601-443774804d1e@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox