From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: <mingo@redhat.com>, <shuah@kernel.org>, <ice_yangxiao@163.com>,
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH] selftests/ftrace: Always enable ftrace_enabled for ftrace testcases
Date: Fri, 3 Apr 2020 23:36:39 +0800 [thread overview]
Message-ID: <5E875807.7040109@cn.fujitsu.com> (raw)
In-Reply-To: <20200403111525.1a713576@gandalf.local.home>
On 2020/4/3 23:15, Steven Rostedt wrote:
>>> Why would it be disabled by default? Anyway, I'm thinking failure is the
>>> > > right answer if ftrace_enable is off.
>> >
>> > Sorry, it seems better to say that ftrace_enabled is disabled by user.
> But then why would you run the tests after disabling it?
Hi Steven,
I disabled it accidentally.
>
>> >
>> > I got 75 pass and 19 failure if ftrace_enable is off. Just have some
>> > questions:
>> >
>> > 1) Is it necessary to run all testcases if ftrace_enable is off?
>> > 2) Is is expected to get pass if ftrace_enable is off?
>> > (I can understand that failure is expected if ftrace_enable is off)
> Because its a way to test the tests!
I think that all tests depend on ftrace_enabled and running them should
report "not supported" or enable it automatically when it is disabled.
Thanks,
Xiao Yang
next prev parent reply other threads:[~2020-04-03 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:29 [PATCH] selftests/ftrace: Always enable ftrace_enabled for ftrace testcases Xiao Yang
2020-04-03 13:22 ` Steven Rostedt
2020-04-03 15:01 ` Xiao Yang
2020-04-03 15:15 ` Steven Rostedt
2020-04-03 15:36 ` Xiao Yang [this message]
2020-04-03 16:31 ` Steven Rostedt
2020-04-04 0:41 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E875807.7040109@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ice_yangxiao@163.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox