Re: [PATCH v3] self_tests/kvm: sync_regs test for diag318

[Collin Walling <walling@linux.ibm.com>]

On 12/7/20 3:19 AM, Christian Borntraeger wrote:
> 
> 
> On 07.12.20 09:16, Janosch Frank wrote:
>> On 12/3/20 10:52 PM, Collin Walling wrote:
>>> The DIAGNOSE 0x0318 instruction, unique to s390x, is a privileged call
>>
>> s/call/instruction/
>>
>>> that must be intercepted via SIE, handled in userspace, and the
>>> information set by the instruction is communicated back to KVM.
>>>
>>> To test the instruction interception, an ad-hoc handler is defined which
>>> simply has a VM execute the instruction and then userspace will extract
>>> the necessary info. The handler is defined such that the instruction
>>> invocation occurs only once. It is up to the caller to determine how the
>>> info returned by this handler should be used.
>>>
>>> The diag318 info is communicated from userspace to KVM via a sync_regs
>>> call. This is tested during a sync_regs test, where the diag318 info is
>>> requested via the handler, then the info is stored in the appropriate
>>> register in KVM via a sync registers call.
>>>
>>> If KVM does not support diag318, then the tests will print a message
>>> stating that diag318 was skipped, and the asserts will simply test
>>> against a value of 0.
>>>
>>> Signed-off-by: Collin Walling <walling@linux.ibm.com>
>>
>> Acked-by: Janosch Frank <frankja@linux.ibm.com>
>>
>> Some nits below.
> 
> Collin, can you have a look at the nits and resubmit soon? Then I can pick this
> for 5.11.
> 

Will do.

[...[


-- 
Regards,
Collin

Stay safe and stay healthy