From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F19D54673 for ; Thu, 18 Sep 2025 01:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758159738; cv=none; b=CwbNGScB7Pvp52ggP/JzVdTxQ3xrdp8WJHLFORXj6FN8W91Ne10A8nU0mDADkIN0j+cILABx0eoQLhYMKjqjsqrm1y1Mqssb3jAm08s8wG9WfXvrvZlhy6SG/ezBWHIWRorwVoMeE9OrLlKwHBvLhIoVP8vjWyylrRayYjQjQ4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758159738; c=relaxed/simple; bh=rdfZa8jgCBx0Z/kzJWH1cObTBcN8b20ZfvsfOn2m9eI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZwLZkYOuzY1E5r8ONl/nrAEWbeIKIcwJoBg6mNfWFmvwivpOljYqevltZ26FiBHfbSkSY3Dy8/yN4ym8i6OAEWcXx2dobB8uVU9j7Y5CU+exOTyUS6chgiMEwxd6yIc1XqiXbOIu9Ped7P0p0VW920BpMKFZnMX06RPly3jAUkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=hrQO9Dq9; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="hrQO9Dq9" Message-ID: <5df18d21-a451-4261-8606-8faa41149028@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1758159724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VK0aNf8yfpHz4wwNcRBOG7PZ4LEkmtROha+wWS9FpmI=; b=hrQO9Dq9bMzluTVloFTx0iPFN5W5c7NwX73MJwymgHVsjC9uKhV3UV6Gi/plzxmqOiQ39Q LSLT4gwnPIYTnlOQ6uAdLqJYwR3zhoUBwzuzJz5yxHRIvbCMPCGubCRTWrJqzOo249v7nL 4q7EIHNA24aorORBSO+DjiwfI9r1lc0= Date: Thu, 18 Sep 2025 09:41:58 +0800 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 1/1] selftests/mm: skip soft-dirty tests when CONFIG_MEM_SOFT_DIRTY is disabled Content-Language: en-US To: Andrew Morton Cc: david@redhat.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, ioworker0@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20250917133137.62802-1-lance.yang@linux.dev> <20250917153046.b781f65ea9a54875f4ddd02e@linux-foundation.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: <20250917153046.b781f65ea9a54875f4ddd02e@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2025/9/18 06:30, Andrew Morton wrote: > On Wed, 17 Sep 2025 21:31:37 +0800 Lance Yang wrote: > >> The madv_populate and soft-dirty kselftests currently fail on systems where >> CONFIG_MEM_SOFT_DIRTY is disabled. >> >> Introduce a new helper softdirty_supported() into vm_util.c/h to ensure >> tests are properly skipped when the feature is not enabled. > > It's pretty sad for us to ship kernels which have known selftest flaws > like this. > > would > > Fixes: 9f3265db6ae8 ("selftests: vm: add test for Soft-Dirty PTE bit") > > be appropriate? Yes. Thanks for providing the Fixes: tag!