From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E84B7DA7D for ; Mon, 23 Sep 2024 14:45:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727102753; cv=none; b=QYAELkehSzTSu9CBn+fLCLkmQOc77gLy5uKOx+dXTX/9riQkguDIOEo4cvuh+TdokQ8WlwBqPHm3vvp7fl43+/ht1xMbkZg661dHywBEXPYNhawmQUXGjYBIuYVRNogtmgrKwqPsbJ0nLufVYJGbc3lIalVm1Wd7Gp5/BIkDvSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727102753; c=relaxed/simple; bh=5NRsXwKuBF1Zs3W/foWqq7Sp7HvXgxKlkNNgfdW03+E=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=h/Fh4GZVUBAPa/3FGcoPfUnahyaWMiaav6mgnOjr583opbd5+yq/Ns8kSRHAcXHaIBz4si9WPv7E04nGTrh0H9LrPK/bcYZzXkjll2AIXeYUt5u6XXC1MQRxJn5Xjmq06QDBdQZlWCIj+ETobpJU8PVKRSDNqtFZxf5NyKDirW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=HMNqhWGg; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="HMNqhWGg" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5365c512b00so5130863e87.3 for ; Mon, 23 Sep 2024 07:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1727102748; x=1727707548; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=5NRsXwKuBF1Zs3W/foWqq7Sp7HvXgxKlkNNgfdW03+E=; b=HMNqhWGgKu/eIzT1ur5rRtOEwMmGCkc16GtyBBEg8ljOIreoFpJwgale+suJWbwFko dWs6sNOOZd/55ENfTMs5CoFNOLyQAqGCbtVj9zfRFfaw/lp5Tob6RO8rHJeuvnX/qEi0 WOTWqNs/y9Q73lTg4yxhn2MWbfd9GYMaTCzw0PAsqIxneNTc+HZG+cpU7JxuqwNhQ/iT wQuY5z840TdmnugHnT0/RpM6mKZuYzbArvAtN/T+D8Bvakz8PfJmw2TXdAV1CArHQDKg sYm69/w6MDEmXV94FdzIUWB2xK0J6kzfLxNCq6s7THr+sugR89Y+b0VBX6w84Efr6n// X+aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727102748; x=1727707548; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5NRsXwKuBF1Zs3W/foWqq7Sp7HvXgxKlkNNgfdW03+E=; b=HGT4zEFHvZwJDz1Nveufr4Aj+wUd68y1tUJAT99A0DAHWtyj4UIUW4ynWFLVDSoTrg aRvWl09AaSMc9UrvpMcxURXI4j+6O1BytS7jXWk34edLSG4LMTAcvU15XBxhIb7cG/eL zmmNyvpiYM1W1SBMxHQ+8kfrVBKEQ9nadU4fjbV+CarrQSj9K5DHEh1QryH7YRc3EOxB IwChzZ7SpFFDxWultmxAQvKoLOztU04/MMAGbWCFp7WKV/ks2ARQsc4u7T58nL+2/TLR aaKc7QCB2VnqBX9aq897JOgHoboC3crvI/lBa0jBC9peTp6wVpWlrVKB2KfGu/INwlUH 4phw== X-Forwarded-Encrypted: i=1; AJvYcCVczbSXTF6Bo/Cnzl7DSrr2Q32LzKDgRKWQrhqMVVbk7N/J4Z5D0UrFdyAED8wBUw735uTnJLg2F+fXk3LQIHE=@vger.kernel.org X-Gm-Message-State: AOJu0YydRl7O9JCf0b0q9UzheTf5wrpaBWoVbl1zq+HBO34ROEHS4ifh OqAaOWhs35WokS1SP1JnecbzcEJe73rB6IjWddHucX1ly9IgSyICGM/rKI4bpmo= X-Google-Smtp-Source: AGHT+IHX9n+o5rnO2Mry3+H4rn2Nsqm42//8eYN5AaanyzprS8/OBlWuUv+9MAznk/hzN2webuG0DQ== X-Received: by 2002:a05:6512:33d6:b0:536:a4d8:917b with SMTP id 2adb3069b0e04-536ac2e5c80mr6152023e87.19.1727102748201; Mon, 23 Sep 2024 07:45:48 -0700 (PDT) Received: from ?IPv6:2804:5078:964:d800:58f2:fc97:371f:2? ([2804:5078:964:d800:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-8493985853asm3121629241.18.2024.09.23.07.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2024 07:45:47 -0700 (PDT) Message-ID: <5e544e68ad83fcdeb3502f1273f18e3d33dc8804.camel@suse.com> Subject: Re: [PATCH v3 0/3] selftests: livepatch: test livepatching a kprobed function From: Marcos Paulo de Souza To: Michael Vetter , linux-kselftest@vger.kernel.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 23 Sep 2024 11:45:44 -0300 In-Reply-To: <20240920115631.54142-1-mvetter@suse.com> References: <20240920115631.54142-1-mvetter@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (by Flathub.org) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2024-09-20 at 13:56 +0200, Michael Vetter wrote: > This patchset adds a test for livepatching a kprobed function. >=20 > Thanks to Petr and Marcos for the reviews! >=20 > V3: > Save and restore kprobe state also when test fails, by integrating it > into setup_config() and cleanup(). > Rename SYSFS variables in a more logical way. > Sort test modules in alphabetical order. > Rename module description. >=20 > V2: > Save and restore kprobe state. >=20 > Michael Vetter (3): > =C2=A0 selftests: livepatch: rename KLP_SYSFS_DIR to SYSFS_KLP_DIR > =C2=A0 selftests: livepatch: save and restore kprobe state > =C2=A0 selftests: livepatch: test livepatching a kprobed function >=20 Thanks for the new version! LGTM, so the series is Reviewed-by: Marcos Paulo de Souza > =C2=A0tools/testing/selftests/livepatch/Makefile=C2=A0=C2=A0=C2=A0 |=C2= =A0 3 +- > =C2=A0.../testing/selftests/livepatch/functions.sh=C2=A0 | 13 +++- > =C2=A0.../selftests/livepatch/test-kprobe.sh=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 | 62 > +++++++++++++++++++ > =C2=A0.../selftests/livepatch/test_modules/Makefile |=C2=A0 3 +- > =C2=A0.../livepatch/test_modules/test_klp_kprobe.c=C2=A0 | 38 +++++++++++= + > =C2=A05 files changed, 114 insertions(+), 5 deletions(-) > =C2=A0create mode 100755 tools/testing/selftests/livepatch/test-kprobe.sh > =C2=A0create mode 100644 > tools/testing/selftests/livepatch/test_modules/test_klp_kprobe.c >=20