From: Jason Gunthorpe <jgg@nvidia.com>
To: iommu@lists.linux.dev, Kevin Tian <kevin.tian@intel.com>,
linux-kselftest@vger.kernel.org
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
kvm@vger.kernel.org, Nicolin Chen <nicolinc@nvidia.com>,
Yi Liu <yi.l.liu@intel.com>
Subject: [PATCH v4 06/17] iommufd: Use the iommufd_group to avoid duplicate MSI setup
Date: Mon, 27 Mar 2023 15:38:00 -0300 [thread overview]
Message-ID: <6-v4-9cd79ad52ee8+13f5-iommufd_alloc_jgg@nvidia.com> (raw)
In-Reply-To: <0-v4-9cd79ad52ee8+13f5-iommufd_alloc_jgg@nvidia.com>
This only needs to be done once per group, not once per device. The once
per device was a way to make the device list work. Since we are abandoning
this we can optimize things a bit.
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
drivers/iommu/iommufd/device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c
index 112b6c541c47e4..0aac63742437aa 100644
--- a/drivers/iommu/iommufd/device.c
+++ b/drivers/iommu/iommufd/device.c
@@ -318,10 +318,6 @@ int iommufd_hw_pagetable_attach(struct iommufd_hw_pagetable *hwpt,
if (rc)
goto err_unlock;
- rc = iommufd_device_setup_msi(idev, hwpt, sw_msi_start);
- if (rc)
- goto err_unresv;
-
/*
* Only attach to the group once for the first device that is in the
* group. All the other devices will follow this attachment. The user
@@ -330,6 +326,10 @@ int iommufd_hw_pagetable_attach(struct iommufd_hw_pagetable *hwpt,
* attachment.
*/
if (list_empty(&idev->igroup->device_list)) {
+ rc = iommufd_device_setup_msi(idev, hwpt, sw_msi_start);
+ if (rc)
+ goto err_unresv;
+
rc = iommu_attach_group(hwpt->domain, idev->igroup->group);
if (rc)
goto err_unresv;
--
2.40.0
next prev parent reply other threads:[~2023-03-27 18:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 18:37 [PATCH v4 00/17] Add iommufd physical device operations for replace and alloc hwpt Jason Gunthorpe
2023-03-27 18:37 ` [PATCH v4 01/17] iommufd: Move isolated msi enforcement to iommufd_device_bind() Jason Gunthorpe
2023-03-27 18:37 ` [PATCH v4 02/17] iommufd: Add iommufd_group Jason Gunthorpe
2023-03-27 18:37 ` [PATCH v4 03/17] iommufd: Replace the hwpt->devices list with iommufd_group Jason Gunthorpe
2023-03-27 18:37 ` [PATCH v4 04/17] iommu: Export iommu_get_resv_regions() Jason Gunthorpe
2023-03-27 18:37 ` [PATCH v4 05/17] iommufd: Keep track of each device's reserved regions instead of groups Jason Gunthorpe
2023-03-27 18:38 ` Jason Gunthorpe [this message]
2023-03-27 18:38 ` [PATCH v4 07/17] iommufd: Make sw_msi_start a group global Jason Gunthorpe
2023-03-27 18:38 ` [PATCH v4 08/17] iommufd: Move putting a hwpt to a helper function Jason Gunthorpe
2023-03-27 18:38 ` [PATCH v4 09/17] iommufd: Add enforced_cache_coherency to iommufd_hw_pagetable_alloc() Jason Gunthorpe
2023-03-27 18:38 ` [PATCH v4 10/17] iommufd: Reorganize iommufd_device_attach into iommufd_device_change_pt Jason Gunthorpe
2023-03-27 18:38 ` [PATCH v4 11/17] iommu: Introduce a new iommu_group_replace_domain() API Jason Gunthorpe
2023-03-27 18:38 ` [PATCH v4 12/17] iommufd: Add iommufd_device_replace() Jason Gunthorpe
2023-03-27 18:38 ` [PATCH v4 13/17] iommufd: Make destroy_rwsem use a lock class per object type Jason Gunthorpe
2023-03-27 18:38 ` [PATCH v4 14/17] iommufd/selftest: Test iommufd_device_replace() Jason Gunthorpe
2023-03-28 5:15 ` Tian, Kevin
2023-03-27 18:38 ` [PATCH v4 15/17] iommufd: Add IOMMU_HWPT_ALLOC Jason Gunthorpe
2023-03-27 18:38 ` [PATCH v4 16/17] iommufd/selftest: Return the real idev id from selftest mock_domain Jason Gunthorpe
2023-03-27 18:38 ` [PATCH v4 17/17] iommufd/selftest: Add a selftest for IOMMU_HWPT_ALLOC Jason Gunthorpe
2023-03-27 20:05 ` [PATCH v4 00/17] Add iommufd physical device operations for replace and alloc hwpt Nicolin Chen
2023-03-29 23:35 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6-v4-9cd79ad52ee8+13f5-iommufd_alloc_jgg@nvidia.com \
--to=jgg@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox