From: Yi Liu <yi.l.liu@intel.com>
To: Baolu Lu <baolu.lu@linux.intel.com>, Jason Gunthorpe <jgg@nvidia.com>
Cc: "joro@8bytes.org" <joro@8bytes.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"lulu@redhat.com" <lulu@redhat.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
"Martins, Joao" <joao.m.martins@oracle.com>
Subject: Re: [PATCH 6/6] iommu/vt-d: Add domain_alloc_user op
Date: Mon, 25 Sep 2023 14:36:58 +0800 [thread overview]
Message-ID: <60384ef3-0176-4ed6-fd05-55e852a38dd1@intel.com> (raw)
In-Reply-To: <ea19494d-8de6-e907-a735-7f2e5f98f9fb@linux.intel.com>
On 2023/9/21 09:31, Baolu Lu wrote:
> On 9/20/23 9:10 PM, Liu, Yi L wrote:
>>>>> +
>>>>> + domain = iommu_domain_alloc(dev->bus);
>>>> No need to bounce between core and driver. Just,
>>>>
>>>> intel_iommu_domain_alloc(IOMMU_DOMAIN_UNMANAGED);
>>>>
>>>> and fully initialize it before return.
>>> If you are going to do that then intel_iommu_domain_alloc() should
>>> fully initialize the domain, not here.
>> I've also considered what Baolu described, but it requires to do some
>> extra initialization which is duplicated with iommu_domain_alloc().
>> So I chose this simple way.
>
> Okay, got you.
>
> Once Jason's paging domain and Robin's bus->iommu_ops retirement series
> have landed, the VT-d driver will need some refactoring. Therefore, I'm
> fine with you using a simpler approach here. I'll refactor everything
> later.
yes.
--
Regards,
Yi Liu
next prev parent reply other threads:[~2023-09-25 6:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 9:25 [PATCH 0/6] iommufd support allocating nested parent domain Yi Liu
2023-09-19 9:25 ` [PATCH 1/6] iommu: Add new iommu op to create domains owned by userspace Yi Liu
2023-09-26 5:28 ` Tian, Kevin
2023-09-26 5:52 ` Yi Liu
2023-09-19 9:25 ` [PATCH 2/6] iommufd/hw_pagetable: Use domain_alloc_user op for domain allocation Yi Liu
2023-09-19 9:25 ` [PATCH 3/6] iommufd/hw_pagetable: Accepts user flags " Yi Liu
2023-09-26 5:29 ` Tian, Kevin
2023-09-19 9:25 ` [PATCH 4/6] iommufd/hw_pagetable: Support allocating nested parent domain Yi Liu
2023-09-20 5:05 ` Baolu Lu
2023-09-25 6:39 ` Yi Liu
2023-09-26 5:32 ` Tian, Kevin
2023-09-26 5:50 ` Yi Liu
2023-09-19 9:25 ` [PATCH 5/6] iommufd/selftest: Add domain_alloc_user() support in iommu mock Yi Liu
2023-09-26 5:33 ` Tian, Kevin
2023-09-19 9:25 ` [PATCH 6/6] iommu/vt-d: Add domain_alloc_user op Yi Liu
2023-09-20 5:28 ` Baolu Lu
2023-09-20 13:05 ` Jason Gunthorpe
2023-09-20 13:10 ` Liu, Yi L
2023-09-20 13:18 ` Jason Gunthorpe
2023-09-25 6:37 ` Yi Liu
2023-09-21 1:31 ` Baolu Lu
2023-09-25 6:36 ` Yi Liu [this message]
2023-09-26 5:36 ` Tian, Kevin
2023-09-20 13:18 ` Liu, Yi L
2023-09-20 5:41 ` Yang, Weijiang
2023-09-20 13:06 ` Jason Gunthorpe
2023-09-20 13:15 ` Liu, Yi L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60384ef3-0176-4ed6-fd05-55e852a38dd1@intel.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox