From: Dev Jain <dev.jain@arm.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
shuah@kernel.org, linux-arm-kernel@lists.infradead.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Anshuman.Khandual@arm.com, suzuki.poulose@arm.com,
ryan.roberts@arm.com, rob.herring@arm.com,
Catalin.Marinas@arm.com, broonie@kernel.org, will@kernel.org,
mark.rutland@arm.com
Subject: Re: [PATCH 2/4] selftests/arm: Add signal tests
Date: Wed, 10 Apr 2024 10:13:16 +0530 [thread overview]
Message-ID: <60db8c70-323b-4e28-8869-6f8166515aec@arm.com> (raw)
In-Reply-To: <1ce0e9c7-0bd3-47c1-893c-3ea5aa95fef5@collabora.com>
On 4/7/24 02:58, Muhammad Usama Anjum wrote:
> On 4/5/24 1:44 PM, Dev Jain wrote:
>> This patch introduces two signal tests, and generic test wrappers similar to
>> selftests/arm64/signal directory, along with the mangling testcases found
>> therein. arm_cpsr, dumped by the kernel to user space in the ucontext structure
>> to the signal handler, is mangled with. The kernel must spot this illegal
>> attempt and the testcases are expected to terminate via SEGV.
>>
>> Signed-off-by: Dev Jain <dev.jain@arm.com>
>> ---
>> .../selftests/arm/signal/test_signals.c | 27 ++
>> .../selftests/arm/signal/test_signals.h | 74 +++++
>> .../selftests/arm/signal/test_signals_utils.c | 257 ++++++++++++++++++
>> .../selftests/arm/signal/test_signals_utils.h | 128 +++++++++
>> .../signal/testcases/mangle_cpsr_aif_bits.c | 33 +++
>> .../mangle_cpsr_invalid_compat_toggle.c | 29 ++
> Too many files/tests in one patch. Break this patch logically into multiple
> tests for easy to review and follow.
In this particular case, I am not sure about the utility of doing that.
My idea was to put the wrapper infrastructure and the individual testcases
into a single patch for ease of comparison with selftests/arm64; this will
actually help in pointing out mistakes or suggesting improvements.
>
>> 6 files changed, 548 insertions(+)
>> create mode 100644 tools/testing/selftests/arm/signal/test_signals.c
>> create mode 100644 tools/testing/selftests/arm/signal/test_signals.h
>> create mode 100644 tools/testing/selftests/arm/signal/test_signals_utils.c
>> create mode 100644 tools/testing/selftests/arm/signal/test_signals_utils.h
>> create mode 100644 tools/testing/selftests/arm/signal/testcases/mangle_cpsr_aif_bits.c
>> create mode 100644 tools/testing/selftests/arm/signal/testcases/mangle_cpsr_invalid_compat_toggle.c
next prev parent reply other threads:[~2024-04-10 4:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 8:44 [PATCH 0/4] A new selftests/ directory for arm compatibility testing Dev Jain
2024-04-05 8:44 ` [PATCH 1/4] selftests/arm: Add mm test Dev Jain
2024-04-06 21:23 ` Muhammad Usama Anjum
2024-04-10 4:15 ` Dev Jain
2024-04-17 4:53 ` Dev Jain
2024-04-05 8:44 ` [PATCH 2/4] selftests/arm: Add signal tests Dev Jain
2024-04-06 21:28 ` Muhammad Usama Anjum
2024-04-08 12:12 ` Mark Brown
2024-04-10 4:43 ` Dev Jain [this message]
2024-04-05 8:44 ` [PATCH 3/4] selftests/arm: Add elf test Dev Jain
2024-04-06 21:30 ` Muhammad Usama Anjum
2024-04-10 4:11 ` Dev Jain
2024-04-05 8:44 ` [PATCH 4/4] selftests: Add build infrastructure along with README Dev Jain
2024-04-06 21:15 ` Muhammad Usama Anjum
2024-04-08 12:24 ` Mark Brown
2024-04-11 5:15 ` Dev Jain
2024-04-05 17:37 ` [PATCH 0/4] A new selftests/ directory for arm compatibility testing Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60db8c70-323b-4e28-8869-6f8166515aec@arm.com \
--to=dev.jain@arm.com \
--cc=Anshuman.Khandual@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rob.herring@arm.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=usama.anjum@collabora.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox