Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: John Hubbard <jhubbard@nvidia.com>,
	Mark Brown <broonie@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Anders Roxell <anders.roxell@linaro.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Ryan Roberts <ryan.roberts@arm.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: Fix arm64 test installation
Date: Fri, 14 Jul 2023 11:48:51 -0600	[thread overview]
Message-ID: <620a5b91-9715-ee28-423c-851506b10832@linuxfoundation.org> (raw)
In-Reply-To: <785e1c1c-84d8-e87d-f22f-9a53d27f30f6@nvidia.com>

On 7/13/23 14:16, John Hubbard wrote:
> On 7/13/23 13:02, Shuah Khan wrote:
>> On 7/10/23 08:04, Mark Brown wrote:
> ...
>>> -kernel_header_files:
>>> -    @ls $(KHDR_DIR)/linux/*.h >/dev/null 2>/dev/null;                      \
>>> -    if [ $$? -ne 0 ]; then                                                 \
>>> -            RED='\033[1;31m';                                                  \
>>> -            NOCOLOR='\033[0m';                                                 \
>>> -            echo;                                                              \
>>> -            echo -e "$${RED}error$${NOCOLOR}: missing kernel header files.";   \
>>> -            echo "Please run this and try again:";                             \
>>> -            echo;                                                              \
>>> -            echo "    cd $(top_srcdir)";                                       \
>>> -            echo "    make headers";                                           \
>>> -            echo;                                                              \
>>> -        exit 1; \
>>> -    fi
>>> -
>>> -.PHONY: kernel_header_files
>>> +all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
>>>   define RUN_TESTS
>>>       BASE_DIR="$(selfdir)";            \
>>>
>>> ---
>>> base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
>>> change-id: 20230710-kselftest-fix-arm64-c023160018d7
>>>
>>> Best regards,
>>
>> Thank you. Will apply the patch for the next rc
>>
>> thanks,
>> -- Shuah
> 
> Hi Shuah,
> 
> Actually, I was hoping that my two fixes [1], [2] could be used, instead
> of reverting the feature.
> 
> 
> [1] https://lore.kernel.org/all/20230711005629.2547838-1-jhubbard@nvidia.com/
> 
> [2] https://lore.kernel.org/all/20230712193514.740033-1-jhubbard@nvidia.com/
> 
> 

Thanks - I will go do that now.

Mark! Are you good with taking these two - do these fix the
problems you are seeing?

thanks,
-- Shuah


  reply	other threads:[~2023-07-14 17:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10 14:04 [PATCH] selftests: Fix arm64 test installation Mark Brown
2023-07-10 20:22 ` John Hubbard
2023-07-10 21:20   ` Mark Brown
2023-07-10 21:31     ` John Hubbard
2023-07-10 22:30       ` Mark Brown
2023-07-10 23:10         ` John Hubbard
2023-07-11 14:00           ` Mark Brown
2023-07-13 20:02 ` Shuah Khan
2023-07-13 20:16   ` John Hubbard
2023-07-14 17:48     ` Shuah Khan [this message]
2023-07-14 18:09       ` Mark Brown
2023-07-14 18:19         ` John Hubbard
2023-07-14 18:26           ` Andrew Morton
2023-07-14 18:32             ` Shuah Khan
2023-07-14 18:36               ` John Hubbard
2023-07-14 19:11                 ` Shuah Khan
2023-07-14 19:39                   ` John Hubbard
2023-07-18 14:54                   ` Mark Brown
2023-07-18 14:56                     ` Shuah Khan
2023-07-18 14:57                       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=620a5b91-9715-ee28-423c-851506b10832@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=anders.roxell@linaro.org \
    --cc=broonie@kernel.org \
    --cc=jhubbard@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=usama.anjum@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox