From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f42.google.com (mail-pz2-f42.google.com [74.125.228.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51CAB39A04F for ; Fri, 18 Sep 2026 23:13:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789773232; cv=none; b=Mgo/YlJ2q/rFG3WGdvftySXEX3mXntQ2Sc31+p6HBOJm5ovCCAjshqu4IqcHdtkcmtAs6TfEcyfyf+zbUFb8yIalpe4fEOQwxJGbJa0KJnjlvuLyKDFz49HQ6IdHutiMiq3eH+7XPHGBXMPBtEp6RuNxwz6hj51PKGKrlERbNV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789773232; c=relaxed/simple; bh=6y+7czlKK/tta15hugGL0Z+zCEcp7uVIfBypdcFDsqA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Rljhwc0IuyYIBGBw9D70b+FbpSD5adkR2hoDjTuApAuJ9Ij5Q/Kt0isROIW0S93StE0M6MNaXKqQiM+QK9JhhGJJ7FXyGyrMd9DtSCh3Cf+o3mUi6J2skNuv5Tbw9iQNczKdarL528cl1diUsfvV+6ti2g387qo1iQVGLip7c/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qaonM2oS; arc=none smtp.client-ip=74.125.228.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qaonM2oS" Received: by mail-pz2-f42.google.com with SMTP id 41be03b00d2f7-cc4d04d73b8so1032158a12.1 for ; Fri, 18 Sep 2026 16:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789773229; x=1790378029; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=6y+7czlKK/tta15hugGL0Z+zCEcp7uVIfBypdcFDsqA=; b=qaonM2oSj9rA2vRwFBptu1pWvPBeFHJO8naAMlXCz2DklGd4IakjylA3t6RGSN2zQn 0GbnXR9rAmJ3VzgYTk5wp98Fm3m4DzajbCfxLr/p/AesoRNEF25C+7A/QZNjexcQh5Zb z1yw2QpAAcc1X6T+x9377dPXOudWIYih/Su8DStT9sljgXqDCsyJ9xgSQkYki95YTKGJ AC+TZH7wftmcRFiCipP3UhpPmBlVBAp9QSaM4Jv2xG258fBC9/FhKdbeAQDCmCaJZRm3 2upBg7KoUSGNPioQTTtN32x584ze20uhkHlLAQEkXPO2w9uOIQS+LwUjxhAy7Gqbe1N+ TalA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789773229; x=1790378029; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6y+7czlKK/tta15hugGL0Z+zCEcp7uVIfBypdcFDsqA=; b=ftG+3sjGELRohQDOkiDKmcDNpbyh8PAPk6dT55rQflkgj6z0FjhRvVOR+1n/MGIYBo pFY2fcJOnCW+oBI1Yz9pr9RosBG24QmWtk4fjwuLuAOc/tKfpAO8qK1AnfzSqSkKobrU jYjgD3UJb1ZOqaS9n3wEcDi4axsi9mp3Ozgc+6GXyXJLP8OArNOCvSb8At6/GN8C+Eve u3RpUloOV7jGNsagRhJhU+R/QZaHAZUnSNvh9SNMvqdV34Vnh87t6xauzxeyqkMvucIN St3tHFmF52i2TvMzGYyEi1cHskGHamnlHIhaKOIPQZ0pOnXrmnepIhpbuSDteLc1McEG RxbQ== X-Forwarded-Encrypted: i=1; AKwUvBwQyAtoFUtNymMm9qP1r6GINz+W8bufnTv1h5pdcwgnvcNXYKk/GrH5iFX/bvx1cK5eHOWNu2w9mrgynVTYFYY=@vger.kernel.org X-Gm-Message-State: AFuF++kaGFsJP87h6AebCfV+ndGurioxLB5DHmr8F3V4ONDoR4EItO5N +1CZMBNGWYnJ40yQZv5tGk9iPEv5KmtSm4VG8YnK3ZuyBTiq+38wmiz2 X-Gm-Gg: AYBFou2njLKuGMf9IiAQhzonopwwuDyFHgAgQ2EGRXKbDhKZVSJxyLD31afeOQKjOJP lyTgpz9lMAH0anzxRzsKCsReTYx9o0QrphGeyovQfBqGbejRiPr1JVaITRELHwNvkPyXaGFeB1x P6sBq2s+G1ub269Ym144fYLNur5T33PN7/Gsl0h0zOXng05ebe17J9rOn9MXtf0d/oYYtD9tUdA 6mibZ6aNvhdTJ4UFrfHnztMhi+mTnHBCHqJJgeNEQtAS6NxB1EnhobAiEVeN+SbcnLYScxJ7uKS FtVGN0s0p6kVWQ6HLqgFwFuv95nAasiMp2QKGHiOaRr5aHWTcV9/7EA1V7yyZmO5KZ+d6grYkac 299UuBwybp2Uxx4pY4NvwQmm/h/ABckurKCHA861QAyvweXsKBFXeUtjWwdBOTzjW8h2r9z70BP BiHnUnHtdYFg8S/SNv6XKAr2HtJv4GRlLaLXnIM/Afw5b0YTDIl7KJvjulReeuemAkaqzYX/5FA e1zfcHHuXQp+ZVCeA957VuvYf12AxfaK805pbicWQU6fo5O44rOloeBng== X-Received: by 2002:a17:90b:4a4e:b0:39e:6c69:34d3 with SMTP id 98e67ed59e1d1-39e6c693665mr1503726a91.55.1789773228966; Fri, 18 Sep 2026 16:13:48 -0700 (PDT) Received: from ?IPv6:2a03:83e0:115c:1:e136:8952:772a:93a4? ([2620:10d:c090:500::4:e681]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33c32f16f9csm1690414eec.2.2026.09.18.16.13.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 16:13:48 -0700 (PDT) Message-ID: <6289e47f004b8b0d5ce55143fb1d55f7306856c0.camel@gmail.com> Subject: Re: [PATCH bpf-next v2 01/13] bpf: move linked-scalar flags out of bpf_reg_state->id [NFC] From: Eduard Zingerman To: Vineet Gupta , Alexei Starovoitov , ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, memxor@gmail.com Cc: martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com, ihor.solodrai@linux.dev, john.fastabend@gmail.com, shuah@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Date: Fri, 18 Sep 2026 16:13:46 -0700 In-Reply-To: References: <20260910164635.459558-1-vineet.gupta@linux.dev> <20260910164635.459558-2-vineet.gupta@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-09-14 at 18:17 -0700, Vineet Gupta wrote: ... > > =C2=A0 static bool regs_exact(const struct bpf_reg_state *rold, > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0const str= uct bpf_reg_state *rcur, > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct bp= f_idmap *idmap) > > =C2=A0 { > > =C2=A0 =C2=A0 =C2=A0 return memcmp(rold, rcur, offsetof(struct bpf_reg_= state, id)) =3D=3D 0 && > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0check_ids(rold->id, rcu= r->id, idmap) && > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0check_ids(rold->parent_= id, rcur->parent_id, idmap); > > =C2=A0 } >=20 > > Also even after above change to check_scalar_ids() the check_scalar_ids= () is still > > no equivalent to check_ids() that regs_exact() is doing. >=20 > ... Right: reverting back to what we had before. > FWIW Eduard had suggested to use regs_exact; I'm not sure if he had=20 > something else in mind which we might be overlooking. I missed the check_scalar_ids() vs check_ids() difference, sorry. Also, yes, let's squash with patch #2. ...