From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Kees Cook <keescook@chromium.org>
Cc: usama.anjum@collabora.com, Shuah Khan <shuah@kernel.org>,
kernel@collabora.com, kernelci@groups.io,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] selftests/lkdtm: add config and turn off CFI_FORWARD_PROTO
Date: Thu, 10 Mar 2022 22:21:57 +0500 [thread overview]
Message-ID: <62c11336-cac1-8501-19fe-980ebfa050e9@collabora.com> (raw)
In-Reply-To: <202203091122.A51B31230A@keescook>
On 3/10/22 12:22 AM, Kees Cook wrote:
> On Fri, Feb 18, 2022 at 01:56:19AM +0500, Muhammad Usama Anjum wrote:
>> Add config options which are needed for LKDTM sub-tests.
>> STACKLEAK_ERASING test needs GCC_PLUGIN_STACKLEAK config.
>> READ_AFTER_FREE and READ_BUDDY_AFTER_FREE tests need
>> INIT_ON_FREE_DEFAULT_ON config.
>>
>> CFI_FORWARD_PROTO always fails as there is no active CFI system of some
>> kind. Turn it off for now by default until proper support.
>
> Building under LTO Clang on arm64, this is available. What's the right
> way to add a CONFIG that isn't always available?
>
> -Kees
Yeah, as you had mentioned
(https://github.com/kernelci/kernelci-project/issues/84#issuecomment-1042015431):
CFI_FORWARD_PROTO is going to fail unless there is an active CFI system
in place of some kind. Right now this depends on arm64+Clang. In the
future, this will be arch-agnostic+Clang, but for the moment, it should
be safe to exclude this test.
In this patch, I'm turning off CFI_FORWARD_PROTO by default here. We can
re-enable it when it becomes arch agnostic. CFI_FORWARD_PROTO cannot be
turned off by using a config. Please let me know your thoughts otherwise.
--
Muhammad Usama Anjum
next prev parent reply other threads:[~2022-03-10 17:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 20:56 [PATCH 1/2] selftests/lkdtm: add config and turn off CFI_FORWARD_PROTO Muhammad Usama Anjum
2022-02-17 20:56 ` [PATCH 2/2] selftests/lkdtm: add config Muhammad Usama Anjum
2022-02-18 15:32 ` Muhammad Usama Anjum
2022-03-09 19:23 ` Kees Cook
2022-03-10 17:22 ` Muhammad Usama Anjum
2022-03-15 11:55 ` Muhammad Usama Anjum
2022-04-04 7:50 ` Muhammad Usama Anjum
2022-04-16 21:13 ` Kees Cook
2022-02-18 15:31 ` [PATCH 1/2] selftests/lkdtm: add config and turn off CFI_FORWARD_PROTO Muhammad Usama Anjum
2022-02-28 7:06 ` Muhammad Usama Anjum
2022-03-08 11:17 ` Muhammad Usama Anjum
2022-03-09 19:22 ` Kees Cook
2022-03-10 17:21 ` Muhammad Usama Anjum [this message]
2022-04-14 11:31 ` Muhammad Usama Anjum
2022-04-16 21:06 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62c11336-cac1-8501-19fe-980ebfa050e9@collabora.com \
--to=usama.anjum@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kernel@collabora.com \
--cc=kernelci@groups.io \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox