linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Zhangjin Wu' <falcon@tinylab.org>, "'w@1wt.eu'" <w@1wt.eu>
Cc: "'arnd@arndb.de'" <arnd@arndb.de>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
	"'linux-kselftest@vger.kernel.org'"
	<linux-kselftest@vger.kernel.org>,
	"'thomas@t-8ch.de'" <thomas@t-8ch.de>,
	"'tanyuan@tinylab.org'" <tanyuan@tinylab.org>
Subject: RE: [RFC] tools/nolibc: replace duplicated -ENOSYS return with single -ENOSYS return
Date: Mon, 28 Aug 2023 09:46:14 +0000	[thread overview]
Message-ID: <6819b8e273dc44e18f14be148549b828@AcuMS.aculab.com> (raw)
In-Reply-To: <4bbdea1710464fa2943663a25bf370c9@AcuMS.aculab.com>

From: David Laight
> Sent: 27 August 2023 22:52
> 
> ...
> > Of course, we can also use the __stringify() trick to do so, but it is
> > expensive (bigger size, worse performance) to unstringify and get the number
> > again, the expensive atoi() 'works' for the numeric __NR_*, but not work for
> > (__NR_*_base + offset) like __NR_* definitions (used by ARM and MIPS), a simple
> > interpreter is required for such cases and it is more expensive than atoi().
> >
> >     /* not for ARM and MIPS */
> >
> >     static int atoi(const char *s);
> >     #define __get_nr(name)          __nr_atoi(__stringify(__NR_##name))
> >     #define __nr_atoi(str)          (str[0] == '_' ? -1L : ___nr_atoi(str))
> >     #define ___nr_atoi(str)         (str[0] == '(' ? -1L : atoi(str))
> >
> > Welcome more discussion or let's simply throw away this direction ;-)
> 
> While it will look horrid the it ought to be possible to
> get the compiler to evaluate the string.
...
> So something that starts:
> #define dig(c) (c < '0' || c > '9' ? 999999 : c - '0')
> 	str[0] == '_' ? -1 :
> 	str[0] != '(' ? str[1] == ' ' ? dig(str[0]) :
> 		str[2] == '1' ? (dig(str[0]) * 10 + dig(str[1]) :
> Any unexpected character will expand the 99999 and generate
> an over-large result.

See https://godbolt.org/z/rear4c1hj

That will convert "1234" or "(1234 + 5678)" (or shorter numbers)
as a compile-time constant.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)


  reply	other threads:[~2023-08-28  9:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-27  8:32 [RFC] tools/nolibc: replace duplicated -ENOSYS return with single -ENOSYS return Zhangjin Wu
2023-08-27  9:17 ` Thomas Weißschuh
2023-08-29  6:29   ` Willy Tarreau
2023-08-30  0:19     ` Zhangjin Wu
2023-08-30  3:25       ` Willy Tarreau
2023-09-01 19:03         ` Zhangjin Wu
2023-09-03  9:31           ` Willy Tarreau
2023-08-27 21:51 ` David Laight
2023-08-28  9:46   ` David Laight [this message]
2023-08-29 23:39     ` Zhangjin Wu
2023-08-30 14:40   ` Ammar Faizi
2023-08-30 16:21     ` David Laight
2023-08-31  7:41       ` Zhangjin Wu
2023-08-31  8:37         ` David Laight
2023-09-01 19:48           ` Zhangjin Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6819b8e273dc44e18f14be148549b828@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=arnd@arndb.de \
    --cc=falcon@tinylab.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=tanyuan@tinylab.org \
    --cc=thomas@t-8ch.de \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).