From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org,
Jakub Kicinski <kuba@kernel.org>,
shuah@kernel.org, willemb@google.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: drv-net: tso: make bkg() wait for socat to quit
Date: Wed, 04 Jun 2025 09:40:44 -0400 [thread overview]
Message-ID: <68404cdc417f3_1e99f529483@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20250604012055.891431-1-kuba@kernel.org>
Jakub Kicinski wrote:
> Commit 846742f7e32f ("selftests: drv-net: add a warning for
> bkg + shell + terminate") added a warning for bkg() used
> with terminate=True. The tso test was missed as we didn't
> have it running anywhere in NIPA. Add exit_wait=True, to avoid:
>
> # Warning: combining shell and terminate is risky!
> # SIGTERM may not reach the child on zsh/ksh!
>
> getting printed twice for every variant.
>
> Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2025-06-04 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 1:20 [PATCH net] selftests: drv-net: tso: make bkg() wait for socat to quit Jakub Kicinski
2025-06-04 13:40 ` Willem de Bruijn [this message]
2025-06-05 15:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68404cdc417f3_1e99f529483@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).