From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A04603672B9; Tue, 12 May 2026 12:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778590699; cv=none; b=Lod8pqQnKdmuWqHd684KFeoIQediXy1haIB+KHBSbS6MFlJTV1tlFHFATFU3+BB8Fkr45zc6LC28URJrnynsiNjuRpoIsUHbW9RGy+JM87zXBXssBcEelJC8BbnB2bN66pSfAcGR3t4ifTABSQWyno/PBmfg5515vIyPJlYyYGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778590699; c=relaxed/simple; bh=o/WDeuINFsO63ke+BSllBznmBDOKR352AUJOXrFgTBA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=llZdQyp9yvjDkjrPVZU9FElvmzRal/xeh0L2Gitxa7+wNrAQaGBrotgDpvmS5iEsg+G87LyyMLYkLJIuK4vA5M1pH+jLQkRYruhCSgRGZHojOMWgxIAzZJSZjFQcj2a48OPpNcMJi1SJDE00BjRx//u0Y3AHpjATnBmGsq1Jz+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=cTo2iYEW; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="cTo2iYEW" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64CC32Zg3185478; Tue, 12 May 2026 12:58:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=BplvGc E2Ie+j0x10pLdH80hGB87ll31uVVquVDCkdiM=; b=cTo2iYEW+xIzdfhk4Kuaqu izH25bpOWlM2wUNN/9BUtgIeYlKOb9HwN0J5X84NEKA0qIs14TEtEkjEua4ZfgVD EcHedAPYNLSwsNlgsh/5BVR8WPucVdCzchtsRJqqawV8lbLEfVdHWCrsnjt3yrNA vnZvwd5I+ywVqcT/nm4fRV0iI0X6K8EXBqZw0KbPDUikHU9VeEOP9AcLXZ53Wn5v 9RqI8Bl+AEReOPvsU9jWtTi7icvAO+jlOV2kZZ5ihY3lxdKwUCc7F6M++d7/fchR R/6r2eD0EkU9IJ7xXfjFH0tBmxpqn+cqaui6RJ4GWrhb5LGiEtwpJo02JKpV0tdA == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4e3nv5b3t5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 May 2026 12:58:04 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64CCsSdl022020; Tue, 12 May 2026 12:58:03 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4e3nfgk5xc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 May 2026 12:58:03 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64CCw2AE32506604 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 May 2026 12:58:02 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 699075804E; Tue, 12 May 2026 12:58:02 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 31E2358054; Tue, 12 May 2026 12:57:56 +0000 (GMT) Received: from [9.124.208.247] (unknown [9.124.208.247]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 12 May 2026 12:57:55 +0000 (GMT) Message-ID: <6963c69e-5bb3-4ac5-96e4-38bc6085d29e@linux.ibm.com> Date: Tue, 12 May 2026 18:27:53 +0530 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Fix mmap() return value check in run_migration_benchmark To: Hongfu Li , jgg@ziepe.ca, leon@kernel.org, akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260512101305.139509-1-lihongfu@kylinos.cn> Content-Language: en-US From: Donet Tom In-Reply-To: <20260512101305.139509-1-lihongfu@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=cPHQdFeN c=1 sm=1 tr=0 ts=6a0323dc cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=q24qZgjzlUWr7uAMhH4A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: rfgdGQ-P0cHhwFn5wwG0kSyXfuOZkn6c X-Proofpoint-GUID: R0fw4q6z-3yitglsWsHUATA4qaUmv1RN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEyMDEzMSBTYWx0ZWRfXwfPzxp/bd2qE ix8KD9eAZ2g8OcQeyfjXWv8RJM1qOdb9/XR72HnCFdI94PHNJEAnY9oTCu+Cd+6M8q5lQR53oUz kTmYouLSdkkFmYexb3uKGcXB03K8LfkMFmcUX10D3hI83e771Men201+Z46LJd8+tJBWqyeVeQm unDlnYrI776v3oeAfV0vxTW22ZrsntleSepc8i9amhYI24I9r5OjTXqy7d6po9RFb9oNQQ7Smus BSOJsFoPi/wA73+TX5jcvRRMYBhb+TpXFnQaW68Bw/MQcyxYg8o6omLhL+l1cDwVLEpEf54LcqG PeAeHxq/h+GaHCmFfOgSiIbxvlhkgPzO2pC8lTe6WLyn6VIGYzKiZ8w52s5KFwA6wIVZM3sIm1O 0DGnXEq1UNkMXeW5Kw9I1/1QMAVmMTYYJLoJqqvVp8qyjItSCiB2lnxzJQkLCSRt0kV8PrUcGdo k5d/MqWkw1FE8oSOYIQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_05,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1011 spamscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605120131 On 5/12/26 3:43 PM, Hongfu Li wrote: > mmap() returns MAP_FAILED on error, not NULL. The current check uses > !buffer->ptr, which evaluates to false when mmap() fails (since > MAP_FAILED is (void *)-1, not 0), so the error path is never taken. > > Signed-off-by: Hongfu Li LGTM Reviewed-by: Donet Tom > --- > tools/testing/selftests/mm/hmm-tests.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/hmm-tests.c b/tools/testing/selftests/mm/hmm-tests.c > index 788689497e92..d72adba5c74e 100644 > --- a/tools/testing/selftests/mm/hmm-tests.c > +++ b/tools/testing/selftests/mm/hmm-tests.c > @@ -2688,7 +2688,7 @@ static inline int run_migration_benchmark(int fd, int use_thp, size_t buffer_siz > buffer->ptr = mmap(NULL, buffer_size, PROT_READ | PROT_WRITE, > MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > > - if (!buffer->ptr) > + if (buffer->ptr == MAP_FAILED) > return -1; > > /* Apply THP hint if requested */