From: Eelco Chaudron <echaudro@redhat.com>
To: Adrian Moreno <amorenoz@redhat.com>
Cc: linux-kselftest@vger.kernel.org, dev@openvswitch.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [ovs-dev] [PATCH net] selftests: openvswitch: fix tcpdump execution
Date: Wed, 18 Dec 2024 11:08:29 +0100 [thread overview]
Message-ID: <6D309AF5-AC5A-4F68-9F86-84E66AC0FB4F@redhat.com> (raw)
In-Reply-To: <20241217211652.483016-1-amorenoz@redhat.com>
On 17 Dec 2024, at 22:16, Adrian Moreno wrote:
> Fix the way tcpdump is executed by:
> - Using the right variable for the namespace. Currently the use of the
> empty "ns" makes the command fail.
> - Waiting until it starts to capture to ensure the interesting traffic
> is caught on slow systems.
> - Using line-buffered output to ensure logs are available when the test
> is paused with "-p". Otherwise the last chunk of data might only be
> written when tcpdump is killed.
>
> Fixes: 74cc26f416b9 ("selftests: openvswitch: add interface support")
> Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
Thank for fixing this, the change looks good to me.
Acked-by: Eelco Chaudron <echaudro@redhat.com>
next prev parent reply other threads:[~2024-12-18 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 21:16 [PATCH net] selftests: openvswitch: fix tcpdump execution Adrian Moreno
2024-12-18 10:08 ` Eelco Chaudron [this message]
2024-12-19 3:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D309AF5-AC5A-4F68-9F86-84E66AC0FB4F@redhat.com \
--to=echaudro@redhat.com \
--cc=amorenoz@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox